Skip to content

FOUR-21522 Fix Get variable list without VarFinder package was not implemented #7912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caleeli merged 3 commits into from
Jan 17, 2025
Merged

FOUR-21522 Fix Get variable list without VarFinder package was not implemented #7912

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ca4df9
Add test for retrieving process variables from screens with pagination
caleeli Jan 16, 2025
db815ec
Implement retrieval of process variables from screens and enhance pag…
caleeli Jan 16, 2025
2d419d1
Add validation for processIds input and ensure pagination parameters …
caleeli Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add test for retrieving process variables from screens with pagination
  • Loading branch information
@caleeli
caleeli committed Jan 16, 2025
commit 9ca4df959af6f5dfe98e5e0daaf9457813f9dab1
90 changes: 90 additions & 0 deletions tests/Feature/Api/V1_1/ProcessVariableControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,58 @@ public function test_can_get_process_variables_with_pagination(): void
$this->assertEquals(30, $responseData['meta']['total']);
}

/**
* Test successful variables retrieval with pagination
*/
public function test_can_get_process_variables_from_process_screens_with_pagination(): void
{
$bpmn = file_get_contents(base_path('tests/Feature/Api/bpmnPatterns/SimpleTaskProcess.bpmn'));
ProcessVariableController::mock(false);
$screen1 = $this->createScreenWithFields(1, 10);
$screen2 = $this->createScreenWithFields(2, 10);
$screen3 = $this->createScreenWithFields(3, 10);
Process::factory()->create(['id' => 1, 'bpmn' => str_replace('pm:screenRef="2"', 'pm:screenRef="' . $screen1->id . '"', $bpmn)]);
Process::factory()->create(['id' => 2, 'bpmn' => str_replace('pm:screenRef="2"', 'pm:screenRef="' . $screen2->id . '"', $bpmn)]);
Process::factory()->create(['id' => 3, 'bpmn' => str_replace('pm:screenRef="2"', 'pm:screenRef="' . $screen3->id . '"', $bpmn)]);

// Make request to the endpoint
$response = $this->apiCall('GET', '/api/1.1/processes/variables?processIds=1,2,3&page=1&per_page=15');

// Assert response structure and status
$response->assertStatus(200)
->assertJsonStructure([
'data' => [
'*' => [
//'id',
//'process_id',
'format',
'label',
'field',
'default',
//'created_at',
//'updated_at',
]
],
'meta' => [
'current_page',
'from',
'last_page',
'path',
'per_page',
'to',
'total',
]
]);

// Assert pagination works correctly
$responseData = $response->json();
$this->assertEquals(15, $responseData['meta']['per_page']);
$this->assertEquals(1, $responseData['meta']['current_page']);

// Since we're generating 10 variables per process (3 processes = 30 total)
$this->assertEquals(30, $responseData['meta']['total']);
}

private function mockVariableFinder(array $processIds, $excludeSavedSearch)
{
// Create a cache key based on process IDs
Expand Down Expand Up @@ -281,4 +333,42 @@ public function test_saved_search_id_filtering(): void
// Check that the total count is reduced by the number of excluded fields
$this->assertEquals(8, $responseData['meta']['total']); // 10 total - 2 excluded
}

/**
* Create a screen with a given number of fields
*
* @param int $processId
* @param int $fieldsCount
*
* @return Screen
*/
private function createScreenWithFields(int $processId, int $fieldsCount)
{
$items = [];
for ($i = 1; $i <= $fieldsCount; $i++) {
$items[] = [
'component' => 'FormInput',
'config' => [
'name' => "var_{$processId}_{$i}",
'type' => 'text',
'label' => "Variable {$i} for Process {$processId}",
'helper' => null,
'dataFormat' => 'string',
'validation' => null,
'placeholder' => null,
],
];
}

return Screen::factory()->create([
'config' => [
[
[
'name' => 'screen name',
'items' => $items,
],
]
],
]);
}
}