Skip to content

FOUR-16001 Implement resources and apiClient to use v1.1 in charts #6959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caleeli merged 7 commits into from
Jun 14, 2024
Merged

FOUR-16001 Implement resources and apiClient to use v1.1 in charts #6959

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2469a74
Enable apiClient 1.1
caleeli Jun 14, 2024
e0f1746
Add resources version 1.1
caleeli Jun 14, 2024
405b140
Fix issues
caleeli Jun 14, 2024
9469f0a
Fix code review issues
caleeli Jun 14, 2024
da6aa2f
Fix code review observations
caleeli Jun 14, 2024
521374d
Use constant for prefix
caleeli Jun 14, 2024
7e054a2
Improve the code to setup multiple version
caleeli Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use constant for prefix
  • Loading branch information
@caleeli
caleeli committed Jun 14, 2024
commit 521374d001f2178fd1499506e68e5008c5efaa35
4 changes: 3 additions & 1 deletion ProcessMaker/Http/Resources/V1_1/TaskResource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ class TaskResource extends ApiResource
{
use TaskResourceIncludes;

const INCLUDE_PREFIX = 'include';

protected static $includeMethods = [
'data',
'user',
Expand Down Expand Up @@ -159,7 +161,7 @@ private function processInclude(Request $request, array $array)
continue;
}

$method = "include" . ucfirst($key);
$method = self::INCLUDE_PREFIX . ucfirst($key);
if (method_exists($this, $method)) {
$attributes = $this->$method();
$array = array_merge($array, $attributes);
Expand Down