Skip to content

FOUR-15875 Optimize Script Tasks Execution with Nayra Engine #6942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caleeli merged 7 commits into from
Jun 12, 2024
Merged

FOUR-15875 Optimize Script Tasks Execution with Nayra Engine #6942

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
88086b4
Merge pull request #6914 from ProcessMaker/FOUR-15871
caleeli Jun 6, 2024
932374f
Add Nayra service as language
caleeli Jun 10, 2024
4fe8577
Add support Nayra to run scripts
caleeli Jun 11, 2024
2de84d5
Run scripts using nayra service
caleeli Jun 11, 2024
d9e7027
Add support for php-nayra to script editor
caleeli Jun 12, 2024
6fa08cf
Create PHP-Nayra executor
caleeli Jun 12, 2024
c90dd09
Add missing down method
caleeli Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add missing down method
  • Loading branch information
@caleeli
caleeli committed Jun 12, 2024
commit c90dd090b87b9e97e132e65ba6a6673d1592bc6f
22 changes: 21 additions & 1 deletion upgrades/2024_06_12_150527_create_nayra_script_executor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
<?php

use Illuminate\Support\Facades\Log;
use ProcessMaker\Models\Script;
use ProcessMaker\Models\ScriptExecutor;
use ProcessMaker\ScriptRunners\Base;
use ProcessMaker\Upgrades\UpgradeMigration as Upgrade;

class CreateNayraScriptExecutor extends Upgrade
{

/**
* Run the upgrade migration.
*
Expand All @@ -22,4 +23,23 @@ public function up()
$scriptExecutor->save();
}
}

/**
* Reverse the upgrade migration.
*
* @return void
*/
public function down()
{
try {
$existsScriptsUsingNayra = Script::where('language', Base::NAYRA_LANG)->exists();
if (!$existsScriptsUsingNayra) {
ScriptExecutor::where('language', Base::NAYRA_LANG)->delete();
} else {
Log::error('There are scripts using Nayra, so the Nayra script executor cannot be deleted.');
}
} catch (Exception $e) {
Log::error('Cannot delete Nayra script executor: ' . $e->getMessage());
}
}
}

@julceslauhub julceslauhub Jun 12, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing "down" method

@caleeli caleeli Jun 12, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing method was added