Skip to content

Refactor some parts of the column filtering functionality #6152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryancooley merged 20 commits into from
Feb 8, 2024
Merged

Refactor some parts of the column filtering functionality #6152

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
205078e
Refactor
nolanpro Feb 3, 2024
a4f030c
Remove console log
nolanpro Feb 5, 2024
7ba1696
Remove console log
nolanpro Feb 5, 2024
609ab18
Remove mixin
nolanpro Feb 5, 2024
37a2589
Remove changes to PmqlInput.vue
nolanpro Feb 5, 2024
6ffa970
Add filter badges
nolanpro Feb 5, 2024
d54b5b7
Update task name
nolanpro Feb 5, 2024
7375f8e
Merge branch 'next' into observation/FOUR-13348
nolanpro Feb 6, 2024
6ef0644
Refactor to use column config for filtering
nolanpro Feb 6, 2024
c78aff2
Refactor column aliases
nolanpro Feb 6, 2024
9c46a72
Continue refactoring advanced filter
nolanpro Feb 7, 2024
35cf25d
Fix order column name
nolanpro Feb 7, 2024
25c7d22
Fix loading advanced filters
nolanpro Feb 7, 2024
2954590
Merge branch 'next' into observation/FOUR-13348
nolanpro Feb 7, 2024
c2f07f4
Remove debugging
nolanpro Feb 7, 2024
8c091a7
Fix default column filter subject type
nolanpro Feb 8, 2024
a4831b2
Update assignees column to search using input instead select
agustinbusso Feb 8, 2024
dea13ec
Remove json2array function
nolanpro Feb 8, 2024
8ca9f2e
Merge branch 'next' into observation/FOUR-13348
nolanpro Feb 8, 2024
61ec2c5
Merge branch 'next' into observation/FOUR-13348
nolanpro Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove console log
  • Loading branch information
@nolanpro
nolanpro authored Feb 5, 2024
commit a4f030c74990762504074c8da141c65480e1b95b
8 changes: 1 addition & 7 deletions resources/js/common/PMColumnFilterPopoverCommonMixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,6 @@ const PMColumnFilterCommonMixin = {
viewProcesses: []
};
},
watch: {
advancedFilter() {
console.log("Advanced filter set", JSON.stringify(this.advancedFilter));
}
},
methods: {
storeFilterConfiguration() {
const { order, type } = this.filterConfiguration();
Expand Down Expand Up @@ -90,7 +85,6 @@ const PMColumnFilterCommonMixin = {
addAliases(json) {
let oldValue, type, value;
for (let i in json) {
console.log("JSON", json[i]);
oldValue = json[i].subject.value;
type = this.getTypeColumnFilter(oldValue);
value = this.getAliasColumnForFilter(oldValue);
Expand Down Expand Up @@ -267,4 +261,4 @@ const PMColumnFilterCommonMixin = {
}
}
};
export default PMColumnFilterCommonMixin;
export default PMColumnFilterCommonMixin;