Skip to content

Inspector tabs for function fit #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jordanmontt merged 4 commits into from
Apr 30, 2026
Merged

Inspector tabs for function fit #335

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d8f645
added inspector tab with plot of function
DurieuxPol Apr 30, 2026
767ed50
Moved inspector method to another package to cut the dependency
jordanmontt Apr 30, 2026
ac299aa
Refactor plotter and table presenter builder to a class. Moved spec c…
jordanmontt Apr 30, 2026
30357b9
added new package to the baseline
jordanmontt Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Moved inspector method to another package to cut the dependency
  • Loading branch information
@jordanmontt
jordanmontt committed Apr 30, 2026
commit 767ed50c339ec961f8462e8180a7ccda14f42a90
22 changes: 0 additions & 22 deletions src/Math-FunctionFit/PMGeneralFunctionFit.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,18 +176,6 @@ PMGeneralFunctionFit >> function: aBlock [
errorFunction function: aBlock
]

{ #category : 'as yet unclassified' }
PMGeneralFunctionFit >> functionPlotTab: anObject [

<inspectorPresentationOrder: 1 title: 'Function plot'>
| plot |
plot := self render.
plot build.
^ (anObject instantiate: SpRoassalInspectorPresenter)
canvas: plot canvas;
yourself
]

{ #category : 'initialization' }
PMGeneralFunctionFit >> initialize [

Expand Down Expand Up @@ -289,16 +277,6 @@ self resetResult .
^errorFunction relativeError: aBoolean
]

{ #category : 'rendering' }
PMGeneralFunctionFit >> render [

| x y plot |
x := data collect: #x.
y := data collect: #y.
plot := RSLinePlot new x: x y: y.
^ plot
]

{ #category : 'operation' }
PMGeneralFunctionFit >> resetBestPoints [
"for repeated evaluating with different starting populations"
Expand Down
13 changes: 13 additions & 0 deletions src/Math-UI/PMGeneralFunctionFit.extension.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
Extension { #name : 'PMGeneralFunctionFit' }

{ #category : '*Math-UI' }
PMGeneralFunctionFit >> inspectorFunctionPlotTab: aBuilder [

<inspectorPresentationOrder: 1 title: 'Function plot'>
| plot |
plot := RSLinePlot points: data.
plot build.
^ (aBuilder instantiate: SpRoassalInspectorPresenter)
canvas: plot canvas;
yourself
]
1 change: 1 addition & 0 deletions src/Math-UI/package.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Package { #name : 'Math-UI' }