Skip to content

Replace unsafe usage of flask.send_file #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pixeebot wants to merge 1 commit into from
Closed

Replace unsafe usage of flask.send_file #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions document-service/src/unstract/document_service/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@
from typing import Any

import redis
from flask import Flask, request, send_file
from flask import Flask, request
from odf import teletype, text
from odf.opendocument import load
import flask
from pathlib import Path

logging.basicConfig(
level=logging.INFO,
Expand Down Expand Up @@ -205,7 +207,7 @@ def find_and_replace():
except Exception as e:
app.logger.error(f"Error while converting file to {output_format} format: {e}")
return f"Error while converting file to {output_format} format!", 500
return send_file(file_name_output, as_attachment=True)
return flask.send_from_directory((p := Path(file_name_output)).parent, p.name, as_attachment=True)


if __name__ == "__main__":
Expand Down