Conversation
A row of tiles under the attachments of an entry: images, the first page of a PDF (PdfRenderer), a frame of a video (read from memory), the first lines of UTF-8 text. A tap shows the image viewer, the page or the whole text in a window; a video opens like "Open". The size is shown next to every attachment.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
A row of tiles under the attachments of an entry, so one sees what is attached without opening it:
BitmapFactorydecodes)ImageViewActivityPdfRenderer)MediaDataSource, with ▶Other attachments get no tile. The size is shown next to every attachment name (
name · 52 KB).PdfRendererneeds a seekable file, so the PDF is written to the private cache only while it is rendered and deleted at once ("Open" already keeps attachments in the cache). Video and text are never written anywhere.All of it is in a new
AttachmentPreview.cs;EntryActivityonly calls it.🔗 Related Issue
None found.
🛠️ Type of Change
✅ Checklist
📸 Screenshots/Videos