Conversation
os.path.join discards the base directory when the user-supplied file_name is an absolute path (e.g. /etc/passwd), allowing an unauthenticated remote attacker to read arbitrary files readable by the server process. Fix: use os.path.basename() to strip all directory components before joining with FILE_PARSE_PATH. Closes PaddlePaddle#11236
|
Thanks for your contribution! |
|
|
|
This Pull Request is stale because it has been open for 60 days with no activity. 当前Pull Request 60天内无活动，被标记为stale。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a path traversal vulnerability in the
/filesdownload endpoint (slm/pipelines/rest_api/controller/file_upload.py).Vulnerability
os.path.join(FILE_PARSE_PATH, file_name)discards the base directory whenfile_nameis an absolute path (e.g./etc/passwd). An unauthenticated remote attacker can read any file readable by the server process.Fix
Use
os.path.basename(file_name)to strip all directory components before joining withFILE_PARSE_PATH.PoC
Closes #11236