Repository navigation
fix: CI/CD build fail for arm64 windows - #14556
Closed
peachismomo wants to merge 1 commit into
Closed
peachismomo wants to merge 1 commit into
peachismomo wants to merge 1 commit into
Conversation
|
Hi @peachismomo, you can manage the labels for this PR by Allowed labels are: Examples: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Fix the Windows ARM64 dependency build failing while building the bundled CPython 3.12.3 source with the newer Windows SDK on the
windows-11-armGitHub Actions runner.Problem
The Windows ARM64 dependency job configures for ARM64 correctly, and CPython is invoked with:
However, CPython builds a host-side
_freeze_module.exehelper before installing the final Python runtime. That helper failed with:This is a known CPython 3.12.3 issue with newer Windows SDKs. Python 3.12.3 still sets its Windows API baseline to Windows 8:
The newer Windows SDK exposes the Process Snapshotting APIs used by
posixmodule.conly for Windows 8.1 or newer, so those declarations are hidden and the_freeze_modulelink fails.Upstream CPython fixed this by moving the Windows build API baseline to Windows 8.1:
python/cpython#124676
Fix
Add a local patch for the pinned
Python-3.12.3.tar.xzsource and apply it during the Windowsdep_python3external project patch step.The patch updates CPython's
PC/pyconfig.hfrom:to:
This makes the Windows SDK expose
PssCaptureSnapshot,PssQuerySnapshot, andPssFreeSnapshot, allowing CPython's_freeze_modulehelper to link successfully.Scope
This does not upgrade bundled Python and does not change OrcaSlicer's embedded Python version. It only backports the upstream CPython build fix to the pinned 3.12.3 source archive.
How to Download Pull Requests Artifacts for Testing