Skip to content

added mean-eddy decomposition function to utils - #8

Merged
dantecn merged 9 commits into
masterfrom
MeanEddy
Jun 9, 2021
Merged

dantecn merged 9 commits into
masterfrom
MeanEddy

Conversation

@dantecn

@dantecn dantecn commented Jun 2, 2021

Copy link
Copy Markdown
Member

No description provided.

@iuryt

iuryt commented Jun 5, 2021

Copy link
Copy Markdown
Member

Should we add this parallel_client? Isn't better just give an example on documentation?

@dantecn

dantecn commented Jun 7, 2021 •

Copy link
Copy Markdown
Member Author

Should we add this parallel_client? Isn't better just give an example on documentation?

Is there a way to have the function defined (so we may call it from other functions), but not available to users? Removing it from __init__ would do the trick?

@iuryt

iuryt commented Jun 8, 2021

Copy link
Copy Markdown
Member

Should we add this parallel_client? Isn't better just give an example on documentation?

Is there a way to have the function defined (so we may call it from other functions), but not available to users? Removing it from __init__ would do the trick?

Usually, functions like this are defined with underscore in other packages ._parallel_client

@dantecn

dantecn commented Jun 9, 2021 •

Copy link
Copy Markdown
Member Author

Should we add this parallel_client? Isn't better just give an example on documentation?

Is there a way to have the function defined (so we may call it from other functions), but not available to users? Removing it from __init__ would do the trick?

Usually, functions like this are defined with underscore in other packages ._parallel_client

Should it be an isolated function, like ls OceanLab
dyn.py eof.py __init.py__ oa.py utils.py ._parallel_client,
or do I create a support.py containing ._parallel client only to be imported by dyn.py etc?

@MariaMigl

Copy link
Copy Markdown
Collaborator

With that approach I believe you can still keep it in the same file(module). However in this case if possible to make it not able to import at all I think it makes more sense than the dunder approach

@dantecn
dantecn merged commit 2b170e7 into master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants