Skip to content

appimage: refactoring extractType2 to avoid use of appimage packer - #81572

Merged
jtojnar merged 4 commits into
NixOS:masterfrom
bignaux:appimage
Mar 4, 2020
Merged

appimage: refactoring extractType2 to avoid use of appimage packer#81572
jtojnar merged 4 commits into
NixOS:masterfrom
bignaux:appimage

Conversation

@bignaux

@bignaux bignaux commented Mar 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Motivation for this change
  • avoid to use appimage packer intend to avoid to modify it (copy then patch it) or execute random unofficial packer, this method should work as non-native unpack ...
  • unify extract simplify code and prepare for next appimage type 3.
    both are steps to make appimage packaging fully automatic.

I let people merge the PR before continuing improvements on this topic.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @tilpner @jtojnar @matthewbauer @worldofpeace

@ofborg ofborg Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Mar 3, 2020
tilpner
tilpner reviewed Mar 4, 2020
View reviewed changes
Comment thread pkgs/build-support/appimage/default.nix Resolved
Comment thread pkgs/build-support/appimage/default.nix Resolved
tilpner
tilpner approved these changes Mar 4, 2020
View reviewed changes

@tilpner tilpner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unityhub fails with and without this PR, nix-review is good for everything else.

@jtojnar
jtojnar merged commit bf83a7c into NixOS:master Mar 4, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Mar 4, 2020
@jtojnar @dtzWill
Merge pull request NixOS#81572 from bignaux/appimage
1f6f17b 
appimage: refactoring extractType2 to avoid use of appimage packer
(cherry picked from commit bf83a7c)
@amesgen amesgen mentioned this pull request Mar 13, 2024
Merged
3 of 13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tilpner tilpner tilpner approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bignaux @tilpner @jtojnar