Skip to content

Cluster, SVM and Aggr Feign Client #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suryag1201 merged 10 commits into from
Oct 16, 2025
Merged

Cluster, SVM and Aggr Feign Client #6

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
951d8ea
CSTACKEX-29 Cluster, SVM and Aggr Feign Client
Oct 14, 2025
85da607
CSTACKEX-29 Change the endpoint method name in feign client
Oct 15, 2025
c35ebc8
CSTACKEX-29 Make the alignment proper
Oct 15, 2025
4a42f58
CSTACKEX-29 Added License Info
Oct 15, 2025
287a8b0
CSTACKEX-29 Resolve Review Comments
Oct 15, 2025
5802f44
CSTACKEX-29 Remove Component Annotation from datastoredriverclass
Oct 15, 2025
0363ab5
CSTACKEX-29 Resolve Style check issues
Oct 15, 2025
a74c021
CSTACKEX-29 Resolve ALL Style issues
Oct 15, 2025
8de7034
CSTACKEX-29 Resolve Precommits Issues
Oct 15, 2025
9ceeb10
CSTACKEX-29 Added Method comments and change the ontap response class…
Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CSTACKEX-29 Added License Info
  • Loading branch information
Gupta, Surya Gupta, Surya
Gupta, Surya authored and Gupta, Surya committed Oct 15, 2025
commit 4a42f58f1cfc266efe053724acc7f167e0eff320
19 changes: 19 additions & 0 deletions .../ontap/src/main/java/org/apache/cloudstack/storage/feign/client/AggregateFeignClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,22 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

package org.apache.cloudstack.storage.feign.client;

import org.apache.cloudstack.storage.feign.model.AggregateResponse;
Expand Down
19 changes: 19 additions & 0 deletions ...me/ontap/src/main/java/org/apache/cloudstack/storage/feign/client/ClusterFeignClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,22 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

package org.apache.cloudstack.storage.feign.client;

import org.apache.cloudstack.storage.feign.FeignConfiguration;
Expand Down
19 changes: 19 additions & 0 deletions ...volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/client/SvmFeignClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,22 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

package org.apache.cloudstack.storage.feign.client;

import org.apache.cloudstack.storage.feign.FeignConfiguration;
Expand Down
22 changes: 14 additions & 8 deletions ...lume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/AggregateResponse.java
View file
Open in desktop

@sandeeplocharla sandeeplocharla Oct 15, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be shifted to model/response

@suryag1201 suryag1201 Oct 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, will create one generic ontap response class

Original file line number Diff line number Diff line change
@@ -1,16 +1,22 @@
/*
* ONTAP REST API
* ONTAP adds support for an expansive RESTful API. The documentation below provides information about the types of API calls available to you, as well as details about using each API endpoint. You can learn more about the ONTAP REST API and ONTAP in the ONTAP 9 Documentation Center: http://docs.netapp.com/ontap-9/topic/com.netapp.doc.dot-rest-api/home.html. NetApp welcomes your comments and suggestions about the ONTAP REST API and the documentation for its use.</br> **Using the ONTAP REST API online documentation** Each API method includes usage examples, as well as a model that displays all the required and optional properties supported by the method. Click the _Model_ link, available with each API method, to see all the required and optional properties supported by each method.
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* OpenAPI spec version: v1
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* NOTE: This class is auto generated by the swagger code generator program.
* https://github.com/swagger-api/swagger-codegen.git
* Do not edit the class manually.
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/


package org.apache.cloudstack.storage.feign.model;

import com.fasterxml.jackson.annotation.JsonInclude;
Expand Down
22 changes: 18 additions & 4 deletions ...storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/Cluster.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,22 @@
/*
*
* Copyright (c) 2020 Netapp, Inc.
* All rights reserved.
*/
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

package org.apache.cloudstack.storage.feign.model;

import com.fasterxml.jackson.annotation.JsonInclude;
Expand Down
21 changes: 17 additions & 4 deletions .../volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/ClusterVersion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,21 @@
/*
*
* Copyright (c) 2020 Netapp, Inc.
* All rights reserved.
*/
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/


package org.apache.cloudstack.storage.feign.model;
Expand Down
22 changes: 17 additions & 5 deletions ...age/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/SvmResponse.java
View file
Open in desktop

@sandeeplocharla sandeeplocharla Oct 15, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a folder 'response' under 'model', we can shift it there

@suryag1201 suryag1201 Oct 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, will create one generic ontap response class

Original file line number Diff line number Diff line change
@@ -1,9 +1,21 @@
/*
*
* Copyright (c) 2020 Netapp, Inc.
* All rights reserved.
*/

* Licensed to the Apache Software Foundation (ASF) under one

@piyush5netapp piyush5netapp Oct 15, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought, can we have class called response.java which accepts generic and we can remove all AggregateResponse etc response objects.

@suryag1201 suryag1201 Oct 15, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

package org.apache.cloudstack.storage.feign.model;

Expand Down
Loading