-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(android): migrate XML layouts to Jetpack Compose #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
cb0cdf0
feat: migrate XML layouts to Jetpack Compose
AchoArnold 4c72697
fix(theme): correct status bar icon color logic
AchoArnold 79adcd8
fix: use painterResource for platform drawables to avoid crash
AchoArnold b43b601
feat: use proper material design icons
AchoArnold a43abcf
style: increase top margin for logo in main screen
AchoArnold cfd0f25
style: increase top loggo padding
AchoArnold 4d33137
style: increase button sizes and icons consistency
AchoArnold 8597b78
style: use normal centered buttons instead of full-width blocks
AchoArnold 2b3a3ce
feat: auto-detect phone numbers on login screen
AchoArnold 4e2ef9d
style: add icons to buttons and improve heartbeat loader width
AchoArnold fadb2fd
style: heart icon color matches button content when disabled
AchoArnold 4a8fe5c
style: update settings screen colors and status bar
AchoArnold 54433fc
fix: address PR review comments\n\n- Improved URL validation in Login…
AchoArnold 0e91686
fix: address more review comments from Copilot and Greptile
AchoArnold 5af4f75
style: set custom status bar color for Android < 12
AchoArnold 795b7f4
style: ensure status bar is white in light mode and matches backgroun…
AchoArnold db7e2f0
style: change top padding to n4 in heartbeats page
AchoArnold 4c74c42
chore: upgrade target/compile SDK to 37 and update all dependencies
AchoArnold db7f800
chore(android): remove unused navigation-compose dependency
AchoArnold a533a2e
style: ensure phone number text color follows theme in MainActivity
AchoArnold File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: upgrade target/compile SDK to 37 and update all dependencies
- Loading branch information
commit 4c74c42205cf4e369d892af01b6139636635fa44
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding \org.jetbrains.kotlin.android\ here actually causes a build conflict: 'Cannot add extension with name \kotlin, as there is an extension already registered'. It seems the plugin is already being applied or configured by the root build file or the Android application plugin. I'll keep it as is since it builds successfully.