Skip to content

allow plugins to use widgets lib #5377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
farfromrefug wants to merge 1 commit into
base: main
Choose a base branch
from
Open

allow plugins to use widgets lib #5377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
allow plugins to use widgets lib 
I have plugins that use classes from the nativescript widget libs.
Now i want to publish the plugin with the java sources directly.
If i do that i need to add `widget-release` to the dependencies.

Now i could do that in the plugin include.gradle, it will make plugin build to work however then app building wont work because the widgets lib will be included twice

So the best solution is automatically add it here.
I am not happy about the path thing, however it will work in all cases.
  • Loading branch information
@farfromrefug
farfromrefug authored Sep 6, 2020
commit 759391e702a288fda581175bb9c80b2504d91876
3 changes: 2 additions & 1 deletion vendor/gradle-plugin/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ dependencies {
}
}
}
implementation files('../../../node_modules/@nativescript/core/platforms/android/widgets-release.aar')
}

def getAppResourcesPath() {
Expand Down Expand Up @@ -99,4 +100,4 @@ def applyBeforePluginGradleConfiguration() {
println "\t + applying user-defined configuration from ${beforePluginGradle}"
apply from: pathToBeforePluginGradle
}
}
}