Skip to content

fix(runtime): generate named Java proxies at runtime when not precompiled #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 4 commits into from
Aug 20, 2026
Merged

fix(runtime): generate named Java proxies at runtime when not precompiled #2016

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e49ac46
fix(runtime): generate named Java proxies at runtime when not precomp…
NathanWalker Aug 20, 2026
40dde17
chore: comment clarity
NathanWalker Aug 20, 2026
d3bbd46
fix(runtime): resolve entry-module paths in Java before crossing JNI
edusperoni Aug 20, 2026
8eb0b86
fix(runtime): content-keyed proxy dex cache; keep the not-found error…
edusperoni Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: comment clarity
  • Loading branch information
@NathanWalker
NathanWalker committed Aug 20, 2026
commit 40dde17955d4762b031d4ce07607e419e6e408f7
13 changes: 7 additions & 6 deletions test-app/runtime/src/main/cpp/ModuleInternal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,12 +626,13 @@ void ModuleInternal::Load(Local<Context> context, const string& path) {
}
// Callers reach here with a project-relative name as readily as an
// absolute one: `Runtime.createJSInstance` hands over whatever a
// generated binding's @JavaScriptImplementation carries, and
// java.io.File has already flattened `./bundle.mjs` to `bundle.mjs`.
// The require branch below resolves such a name against the app root;
// the ES module branch goes straight to the filesystem, so anchor it
// here or it fails as "Cannot find module" from whatever the process
// cwd happens to be.
// generated binding's @JavaScriptImplementation carries, and that is
// `./bundle.mjs` by SBG convention — a module name in the app-root
// namespace, not a filesystem path. The require branch below resolves
// such names against the app root; the ES module branch stats the
// string as-is (after CanonicalizeRegistryKey folds `./` away), so
// anchor it here or it resolves against the process cwd and fails as
// "Cannot find module bundle.mjs".
LoadESModule(isolate, AnchorToAppRoot(path, isHttpModule), BootEntryEvaluationOptions(isHttpModule));
if (isHttpModule) {
TNS_DEBUG(Esm, "run-module http-esm ok %s", NormalizeHttpModuleUrl(path).c_str());
Expand Down