fix(vite): decode dots in prebundled subpath specifiers - #11466
Merged
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit 0fc690a
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
triniwiz
force-pushed
the
fix/vite-prebundle-subpath-dots
branch
from
September 28, 2026 04:56
142437a to
9f2916f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Vite's
flattenIdencodes/as_and.as__.viteDepsPathToBareSpecifier(and the shared-alias lookup next to it) decoded a vendored package's subpath by turning every_into/, so dots came back as//. For example,pkg_lib_file__jsbecamepkg/lib/file//js, and the request 404'd.What is the new behavior?
One
decodeFlattenedSubpathhelper decodes__to.first, then_to/, and both decode sites use it.Tests:
packages/vite/hmr/server/websocket-module-specifiers.prebundle.spec.ts(3) covers a dotted subpath, an extensionless subpath, a scoped package, and the package's own prebundle.