Skip to content

devel branch for CI pipeline #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
couture-ql wants to merge 9 commits into
base: main
Choose a base branch
from
Open

devel branch for CI pipeline #19

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7fb9f10
add AuthorizedSession support
runawaycoast Jun 10, 2022
784a11f
add test for api_config
runawaycoast Jun 13, 2022
bfaa3b0
fix session object not getting through
runawaycoast Jun 15, 2022
b7dca2b
clean request payload
runawaycoast Jun 15, 2022
01e4a11
fix get api_config before params assignment
runawaycoast Jun 15, 2022
1a990da
add test and fix lint
runawaycoast Jun 16, 2022
78cacae
add strip function to remove property in option
runawaycoast Jun 16, 2022
e87eee2
fix lint, add doc for AuthorizedSession
runawaycoast Aug 12, 2022
bfe9e08
Merge branch 'rr/auth-session-support' into devel
couture-ql Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix session object not getting through
  • Loading branch information
@runawaycoast
runawaycoast committed Aug 16, 2022
commit bfaa3b05ede7ae38501ff28b5da1b21500d12bef
3 changes: 1 addition & 2 deletions nasdaqdatalink/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,7 @@ def request(cls, http_verb, url, **options):

@classmethod
def execute_request(cls, http_verb, url, **options):
params = getattr(options, 'params', None)
session = getattr(params, 'session', None)
session = options.get('params', {}).get('session', None)
if session is None:
session = cls.get_session()

Expand Down
5 changes: 3 additions & 2 deletions test/test_authorized_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
from unittest import TestCase
from unittest.mock import patch

from nasdaqdatalink.model.authorized_session import AuthorizedSession
from nasdaqdatalink.api_config import ApiConfig
from requests.sessions import Session
Expand All @@ -18,7 +16,10 @@ def test_authorized_session_assign_correct_internal_config(self):
self.assertTrue(isinstance(authed_session._api_config, ApiConfig))

def test_authorized_session_pass_created_session(self):
ApiConfig.use_retries = True
ApiConfig.number_of_retries = 130
authed_session = AuthorizedSession()
self.assertTrue(isinstance(authed_session._auth_session, Session))
adapter = authed_session._auth_session.get_adapter(ApiConfig.api_protocol)
self.assertTrue(isinstance(adapter, HTTPAdapter))
self.assertEqual(adapter.max_retries.connect, 130)