Skip to content

Implement P3149R11 and P3815R1 #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericniebler merged 20 commits into from
Feb 10, 2026
Merged

Implement P3149R11 and P3815R1 #1713

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
8791891
Add stdexec::scope_association
ispeters Dec 14, 2025
86e22ef
Add stdexec::scope_token
ispeters Dec 15, 2025
2c65dac
Add stdexec::associate
ispeters Dec 16, 2025
08d1308
Add stdexec::__stop_when
ispeters Dec 22, 2025
29c0b28
Add stdexec::spawn
ispeters Dec 22, 2025
401f608
Add stdexec::simple_counting_scope and stdexec::counting_scope
ispeters Dec 23, 2025
a63340d
Add stdexec::spawn_future
ispeters Dec 27, 2025
5209ffd
Implement the missing "stop-request forwarding" behaviour
ispeters Dec 28, 2025
94c4874
fixes
ericniebler Feb 10, 2026
21d29e7
Fix MSVC build
ispeters Feb 10, 2026
2775f7c
Conform to coding standard
ispeters Feb 10, 2026
6dbc80a
Use __mapply_q
ispeters Feb 10, 2026
343fc43
Prefer cascading constexpr ifs
ispeters Feb 10, 2026
22fd39d
Devirtualize __spawn_state_base
ispeters Feb 10, 2026
fcb41d0
Devirtualize spawn_future
ispeters Feb 10, 2026
afd6e39
Update the completion signature computation for __spawn_future_state
ispeters Feb 10, 2026
9199dcc
Remove __monostate from future's completion variant
ispeters Feb 10, 2026
892f971
Fix Clang 16 build
ispeters Feb 10, 2026
bdb7f09
Fix MSVC build
ispeters Feb 10, 2026
3303429
`__callback` is magic on msvc
ericniebler Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Conform to coding standard 
* Eliminate camel case
* Uglify all identifiers
* `s/\bassert\b/STDEXEC_ASSERT/g`
* Take the address of objects with `std::addressof`
  • Loading branch information
@ispeters
ispeters committed Feb 10, 2026
commit 2775f7cf61b497cf287d9e1b66aee72ee031032b
22 changes: 11 additions & 11 deletions include/stdexec/__detail/__associate.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ namespace STDEXEC {
requires __std::copy_constructible<__wrap_sender_t>
: __assoc_(__other.__assoc_.try_associate()) {
if (__assoc_) {
std::construct_at(&__sndr_, __other.__sndr_);
std::construct_at(std::addressof(__sndr_), __other.__sndr_);
}
}

Expand All @@ -106,15 +106,15 @@ namespace STDEXEC {
}

std::pair<__assoc_t, __sender_ref> release() && noexcept {
__sender_ref u(__assoc_ ? std::addressof(__sndr_) : nullptr);
return {std::move(__assoc_), std::move(u)};
__sender_ref __u(__assoc_ ? std::addressof(__sndr_) : nullptr);
return {std::move(__assoc_), std::move(__u)};
}

private:
explicit __associate_data(std::pair<__assoc_t, __sender_ref> __parts)
: __assoc_(std::move(__parts.first)) {
if (__assoc_) {
std::construct_at(&__sndr_, std::move(*__parts.second));
std::construct_at(std::addressof(__sndr_), std::move(*__parts.second));
}
}

Expand Down Expand Up @@ -164,23 +164,23 @@ namespace STDEXEC {
__op_t __op_;
};

explicit __op_state(std::pair<__assoc_t, __sender_ref_t> parts, _Receiver&& __rcvr)
: __assoc_(std::move(parts.first)) {
explicit __op_state(std::pair<__assoc_t, __sender_ref_t> __parts, _Receiver&& __rcvr)
: __assoc_(std::move(__parts.first)) {
if (__assoc_) {
::new ((void*) std::addressof(__op_))
__op_t(connect(std::move(*parts.second), std::move(__rcvr)));
__op_t(connect(std::move(*__parts.second), std::move(__rcvr)));
} else {
std::construct_at(std::addressof(__rcvr_), std::move(__rcvr));
}
}

explicit __op_state(__associate_data_t&& ad, _Receiver&& __rcvr)
: __op_state(std::move(ad).release(), std::move(__rcvr)) {
explicit __op_state(__associate_data_t&& __ad, _Receiver&& __rcvr)
: __op_state(std::move(__ad).release(), std::move(__rcvr)) {
}

explicit __op_state(const __associate_data_t& ad, _Receiver&& __rcvr)
explicit __op_state(const __associate_data_t& __ad, _Receiver&& __rcvr)
requires __std::copy_constructible<__associate_data_t>
: __op_state(__associate_data_t(ad).release(), std::move(__rcvr)) {
: __op_state(__associate_data_t(__ad).release(), std::move(__rcvr)) {
}

~__op_state() {
Expand Down
Loading
Loading