Conversation
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 2, 2026 04:39
|
🌿 Preview your docs: https://nvidia-preview-pr-4104.docs.buildwithfern.com/openshell |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GNU Make fails to launch even a
truerecipe because the sandbox denies its identity-preservingsetresuidandsetresgidcalls. Allow those calls only when every argument is the established workload ID or-1, so recipes run while identity changes remain denied.Related Issue
Closes #4102
Changes
setresuid/setresgidblocks with argument checks. Other credential setters and supplementary-group changes remain blocked.Testing
cargo test -p openshell-isolation-interface: 54 tests passed.-D warningspassed for the isolation interface, sandbox, and new E2E test; Rust formatting checks passed.mise run docspassed with zero errors and three warnings.make: true: Operation not permitted/Error 127; the patched runtime passes startup, piped exec, and terminal exec with UID 10001 and GID 10002.build:docker:sandboxtask. The comparison uses the same gateway, CLI, supervisor image, and workload fixture for both runtime images.Checklist
The change introduces no configuration, protocol, or architecture changes. The related public skills do not describe these syscall restrictions, so they need no update.