Conversation
Run image preparation in an owned worker process, reserve its process identity until cleanup completes, and protect staging with leases so cancellation and recovery cannot race with another preparation attempt. Signed-off-by: Shiju <shiju@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-4039.docs.buildwithfern.com/openshell |
shiju-nv
changed the base branch from
main
to
fix/3950-vm-workload-identity-021400
October 1, 2026 11:40
shiju-nv
added this pull request to stack #4041
October 1, 2026 11:51
shiju-nv
marked this pull request as ready for review
October 1, 2026 19:20
shiju-nv
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 1, 2026 19:20
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A timeout or cancellation can abort a sandbox's async preparation task while blocking filesystem work continues and temporary files remain. Run image and overlay preparation in an owned worker process. On cancellation, stop its process group and wait for cleanup before reclaiming files. Recover inactive attempts after driver restart.
Related Issue
Fixes #3953, accepted by a maintainer on 2026-09-30. Part of #3955. Depends on the workload-identity change in #4036.
Changes
EPERMcase.Testing
mise run pre-commitpasses locally. Focused local checks and the linked Branch Checks passed.Checklist