Skip to content

Feat: Add async policy evaluation, typed side effects, and runtime namespace refactor #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rian-be merged 14 commits into from
Jun 30, 2026
Merged

Feat: Add async policy evaluation, typed side effects, and runtime namespace refactor #43

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b2d61d4
feat(core): add typed side effect contracts
rian-be Jun 29, 2026
bf96299
test(core): cover typed side effect payloads
rian-be Jun 29, 2026
394b419
docs(examples): demonstrate typed side effect usage
rian-be Jun 29, 2026
4250981
refactor(storage): extract in-memory query materialization helpers
rian-be Jun 30, 2026
304d5bd
refactor(execution): delegate governed execution result handling
rian-be Jun 30, 2026
a8c444c
feat(queries): support side effect request filters
rian-be Jun 30, 2026
90a063f
refactor(redis): align query materialization with evaluator split
rian-be Jun 30, 2026
0267129
test(redis): cover side effect serialization and queries
rian-be Jun 30, 2026
97f4adc
feat(abstractions): add async mutation policy contract
rian-be Jun 30, 2026
1b1aa12
feat(abstractions): add policy evaluation exceptions
rian-be Jun 30, 2026
e504133
refactor(runtime): reorganize Internal into Execution and Evaluation …
rian-be Jun 30, 2026
82c9f66
feat(runtime): extract Diagnostics into Runtime.Diagnostics namespace
rian-be Jun 30, 2026
359e711
docs(runtime): replace inheritdoc with explicit XML docs in MutationE…
rian-be Jun 30, 2026
c0e0837
test(core): cover mixed sync and async policy evaluation
rian-be Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(redis): cover side effect serialization and queries
  • Loading branch information
@rian-be
rian-be committed Jun 30, 2026
commit 0267129d4b4f608b5071b3c068931df8dd83da72
28 changes: 28 additions & 0 deletions Examples/Governance/RedisQueries/Scenarios/GovernanceRedisQueriesScenario.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
using Microsoft.Extensions.DependencyInjection;
using ModularityKit.Mutator.Abstractions.Context;
using ModularityKit.Mutator.Abstractions.Effects;
using ModularityKit.Mutator.Abstractions.Intent;
using ModularityKit.Mutator.Abstractions.Policies;
using ModularityKit.Mutator.Governance.Abstractions.Lifecycle.Model;
using ModularityKit.Mutator.Governance.Abstractions.Queries.Contracts;
using ModularityKit.Mutator.Governance.Abstractions.Queries.Model.Approvals;
using ModularityKit.Mutator.Governance.Abstractions.Queries.Model.Decisions;
using ModularityKit.Mutator.Governance.Abstractions.Queries.Model.Requests;
using ModularityKit.Mutator.Governance.Abstractions.Queries.Model.Requests.Filters;
using ModularityKit.Mutator.Governance.Abstractions.Requests.Decisions;
using ModularityKit.Mutator.Governance.Abstractions.Requests.Factory;
using ModularityKit.Mutator.Governance.Abstractions.Requests.Model;
Expand Down Expand Up @@ -50,6 +52,16 @@ public static async Task Run()
ApproverIds = new HashSet<string> { "security-lead" }
}));

PrintSection("Requests With Actionable Side Effects");
PrintRequests(await queryStore.QueryAsync(new MutationRequestQuery
{
SideEffects = new MutationRequestSideEffectFilter
{
DataContractTypes = new HashSet<string> { "examples.redis.execution-side-effect" },
RequiresAction = true
}
}));

PrintSection("Recent Execution Outcomes");
PrintDecisions(await queryStore.GetRecentDecisionsAsync(
MutationRequestDecisionQuery.RecentExecutionOutcomes(),
Expand Down Expand Up @@ -152,6 +164,16 @@ private static MutationRequest CreateExecutedRequest(
CreatedAt = executedAt.AddMinutes(-15),
UpdatedAt = executedAt,
ExecutedAt = executedAt,
SideEffects =
[
SideEffect.Critical(
type: "ExecutedRequestRequiresFollowUp",
description: "Executed request still requires manual follow-up",
data: new RedisExecutionSideEffectData
{
Ticket = "BILL-12"
})
],
Decisions =
[
MutationRequestDecision.Lifecycle(
Expand All @@ -178,6 +200,12 @@ private static MutationRequest CreateExecutedRequest(
]
};

[SideEffectDataContract("examples.redis.execution-side-effect", 1)]
private sealed record RedisExecutionSideEffectData
{
public required string Ticket { get; init; }
}

private static void PrintSection(string title)
{
Console.WriteLine();
Expand Down
24 changes: 23 additions & 1 deletion ...or.Governance.Redis.Tests/Serialization/Converters/RedisMutationRequestSerializerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using ModularityKit.Mutator.Abstractions.Context;
using ModularityKit.Mutator.Abstractions.Effects;
using ModularityKit.Mutator.Abstractions.Intent;
using ModularityKit.Mutator.Abstractions.Policies;
using ModularityKit.Mutator.Governance.Abstractions.Lifecycle.Model;
Expand Down Expand Up @@ -61,7 +62,17 @@ public void Roundtrip_preserves_request_shape_needed_by_governance_runtime()
with
{
CreatedAt = new DateTimeOffset(2026, 6, 25, 9, 0, 0, TimeSpan.Zero),
UpdatedAt = new DateTimeOffset(2026, 6, 25, 9, 5, 0, TimeSpan.Zero)
UpdatedAt = new DateTimeOffset(2026, 6, 25, 9, 5, 0, TimeSpan.Zero),
SideEffects =
[
SideEffect.Critical(
type: "WorkflowRejected",
description: "Workflow rejection requires action",
data: new RedisGovernanceSideEffectData
{
Ticket = "INC-42"
})
]
};

var json = RedisMutationRequestSerializer.Serialize(request);
Expand All @@ -75,9 +86,20 @@ public void Roundtrip_preserves_request_shape_needed_by_governance_runtime()
Assert.Equal(BlastRadiusScope.Module, roundtrip.Intent.EstimatedBlastRadius?.Scope);
Assert.Equal("platform", roundtrip.Intent.Metadata["risk-owner"]);
Assert.Equal("security", roundtrip.Metadata["team"]);
Assert.Single(roundtrip.SideEffects);
Assert.Equal("WorkflowRejected", roundtrip.SideEffects[0].Type);
Assert.Equal("redis.governance.side-effect", roundtrip.SideEffects[0].DataContractType);
Assert.True(roundtrip.SideEffects[0].TryGetData<RedisGovernanceSideEffectData>(out var sideEffectData));
Assert.Equal("INC-42", sideEffectData!.Ticket);
Assert.Single(roundtrip.Requirements);
Assert.Single(roundtrip.ApprovalRequirements);
Assert.Equal("security-lead", roundtrip.ApprovalRequirements[0].ApproverId);
Assert.Equal(3, roundtrip.Decisions.Count);
}

[SideEffectDataContract("redis.governance.side-effect", 1)]
private sealed record RedisGovernanceSideEffectData
{
public required string Ticket { get; init; }
}
}