Skip to content

Add Python 3.10 support: use Py_SET_SIZE() #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1st1 merged 3 commits into from
Dec 7, 2020
Merged

Add Python 3.10 support: use Py_SET_SIZE() #52

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b95cba8
Add Python 3.10 support: use Py_SET_SIZE()
vstinner Dec 4, 2020
5dfb6bf
Move the include
vstinner Dec 4, 2020
a39917e
Update pythoncapi_compat.h
vstinner Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move the include
  • Loading branch information
@vstinner
vstinner committed Dec 4, 2020
commit 5dfb6bfde50cdb45021b2491f1cea976afbeff5e
3 changes: 1 addition & 2 deletions immutables/_map.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#include "pythoncapi_compat.h"

#include <stddef.h> /* For offsetof */
#include "pythoncapi_compat.h"

@1st1 1st1 Dec 4, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means we need to drop support for Python 3.5, right?

@vstinner vstinner Dec 4, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated https://github.com/pythoncapi/pythoncapi_compat to support Python 2.7, 3.4 and 3.5 as well.

I updated pythoncapi_compat.h to the latest version in my PR.

@vstinner vstinner Dec 4, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.5 was already supported by I was too lazy to port the tests to Python 3.5. Since I'm trying to use pythoncapi_compat.h on Mercurial which still supports Python 2.7, I ported it to Python 2.7, 3.4 and 3.5. And 2.7 and 3.5 are now tested on the project CI.

#include "_map.h"


Expand Down