Extend MAL force English titles to recommendations and related - #4227
Open
IrishBruse wants to merge 9 commits into
Open
IrishBruse wants to merge 9 commits into
IrishBruse wants to merge 9 commits into
Conversation
Centralize MAL title selection and apply it to recommendations, related entries, search results, and single entry titles when the option is on.
Use the repo test stack instead of vitest and resolve related English titles with Promise.all to satisfy airbnb no-restricted-syntax.
Share MAL page English title parsing, simplify legacy related resolution, and limit title helper usage to overview-related paths.
Request full related node fields from the MAL API, parallelize recommendation title and list enrichment, and drop the helper unit test.
IrishBruse
marked this pull request as ready for review
September 22, 2026 01:04
Entries such as the Depressed Magician manga only list English names as synonyms, so overview related and recommendation cards no longer keep the long romanized title when force English titles is on.
Member
|
Quite a lot of requests. Do you want us to get banned by Mal? 😅 We will only accept an implementation without additional requests. |
Contributor
Author
|
Should be a lot quieter on the network now. There is 1 extra call for related titles on legacy MAL because the scraped HTML doesn’t include English titles. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
MALSync already had a Force English titles setting for some MAL views. This change extends that behavior to the Related and Recommendations sections on anime/manga overview pages.
Nothing changes unless Force English titles is turned on in settings. With the setting off, titles stay exactly as MAL shows them today.
When the setting is on, those sections use the English title from MAL when it is available, and fall back to the default title if not.
Screenshots (Force English on)
Related section:
Off:
On:
Recommendations: