[Bug] Fix setuptools packaging: include all lcb_runner subpackages - #156
Open
PharosEast wants to merge 1 commit into
Open
PharosEast wants to merge 1 commit into
PharosEast wants to merge 1 commit into
Conversation
Signed-off-by: PharosEast <920086012@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A non-editable
pip installof this repo yields a brokenlcb_runnerpackage: onlythe top-level module is shipped because
pyproject.tomlpinspackages = ["lcb_runner"]. All subpackages (benchmarks,evaluation,prompts,runner,utils) are missing, so the harness is unusable for anyone installingnon-editable (pip install . / wheel / sdist / container images). The README's
editable
-e .flow masks the issue.Changes
pyproject.toml: replace the explicit package list with[tool.setuptools.packages.find] include = ["lcb_runner*"]so all subpackages arediscovered and shipped. No runtime code changes.
Test Plan
pip install .(oruv pip install .).python -c "import lcb_runner.evaluation.testing_util"succeeds.python -m lcb_runner.runner.main --helpis reachable.lcb_runner.evaluation.compute_code_generation_metrics.check_correctnesson a call-based and a stdio sample (correct solution passes, wrong solution fails).
Test Result
site-packages/lcb_runner/containsbenchmarks,evaluation,prompts,runner,utils.