📩 fix: Stage URL Prompts Before Agent Submission - #16647
Conversation
|
Head: |
|
Head: |
|
Head: |
|
Head: |
|
Head: |
|
Head: |
|
Head: |
|
Head: |
|
Head: |
|
Head: |
|
@codex review the latest head, final review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Head: |
|
Head: |
|
Head: |
|
Head: |
|
Head: |
|
Head: |
|
Head: |
|
Head: |
|
Head: |
|
Head: |
|
Head: |
|
Head: |
Summary
?agent_id=…&q=hi&submit=trueleft the composer blank while applying settings, then could send after a three-second fallback. Readiness compared URL settings with differently normalized conversation fields.Stage the prompt immediately and show localized “Sending…” feedback. Submit once the requested settings match. On timeout, retain the draft with review guidance instead of sending to the wrong configuration. Typed, dictation, steering, and queue actions respect preparation; Stop and Cancel remain available.
How it works
Preserve explicit spec overrides, hidden-spec resolution, source/destination drafts, and project scope. Compare settings using endpoint-schema and conversation-builder semantics. Later prompt URLs work in the already-mounted composer, including “Start in a new chat” queue actions.
Type of change
Testing
At
eda94f7c165b067d9418ffc6bd48365d444b57b7:npx tsc --noEmit: passed.hionce; unapplied settings retain the visible prompt; queued messages start a fresh chat without also sending in the source chat.Three SPA-navigation integration controls failed before the fix. Coverage also includes normalization, hidden specs, draft ownership, cancellation, stale validation/timeout callbacks, and alternate submission paths.
Screenshots / recordings
Real-app screenshots and recordings were captured. GitHub asset upload rejected App authentication; no assets were uploaded or committed. Before capture was capacity-blocked.
Risk / compatibility
The existing settings timeout no longer auto-sends an unapplied configuration. The prompt remains available for review and manual send. Auto-submit policy, stored drafts, hidden specs, explicit settings, and project routing are preserved.
Checklist