Repository navigation
scripts: Add windows-build-tarball.ps1 - #21
Merged
Merged
Conversation
jcfr
reviewed
Oct 9, 2018
| @@ -0,0 +1,7 @@ | |||
| # This script creates a tarball of the VTK Python package build tree. It is | |||
Collaborator
There was a problem hiding this comment.
This script creates an archive ...
thewtex
force-pushed
the
windows-tarball
branch
from
October 9, 2018 19:52
0bbf021 to
94c9acc
Compare
jcfr
reviewed
Oct 9, 2018
| # This script creates an archive of the VTK Python package build tree. It is | ||
| # downloaded by the external module build scripts and used to build their | ||
| # Python package on GitHub CI services. | ||
|
|
Collaborator
There was a problem hiding this comment.
Should we also add a comment like:
... on GitHub CI services.
It was designed to be executed on overload.kitware build machine and is invoked in XXXX after
ZZZ.
Collaborator
There was a problem hiding this comment.
Excellent. Thanks for taking the time to accommodate all these nitpicks 👍
thewtex
force-pushed
the
windows-tarball
branch
from
October 10, 2018 16:02
94c9acc to
db42053
Compare
Collaborator
|
An other nitpick would be to rename these script from |
Collaborator
|
Or even better, something like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.