Skip to content

Cancellation token in SpotifyClient::PaginateAll for passing to Paginator #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnnyCrazy merged 2 commits into from
Nov 3, 2023
Merged

Cancellation token in SpotifyClient::PaginateAll for passing to Paginator #907

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
777457e
adding cancellation token in SpotifyClient::PaginateAll and passing t…
Sarsoo Sep 24, 2023
b30c96f
adding docstring for cancellation token
Sarsoo Sep 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
adding cancellation token in SpotifyClient::PaginateAll and passing t… 
…o IPaginator
  • Loading branch information
@Sarsoo
Sarsoo committed Sep 24, 2023
commit 777457e2858c42bcbd6e301bc1e7a3469083707b
2 changes: 1 addition & 1 deletion SpotifyAPI.Web/Clients/Interfaces/ISpotifyClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public interface ISpotifyClient
/// <param name="paginator">Optional. If not supplied, DefaultPaginator will be used</param>
/// <typeparam name="T">The Paging-Type</typeparam>
/// <returns>A list containing all fetched pages</returns>
Task<IList<T>> PaginateAll<T>(IPaginatable<T> firstPage, IPaginator? paginator = default!);
Task<IList<T>> PaginateAll<T>(IPaginatable<T> firstPage, IPaginator? paginator = default!, CancellationToken cancellationToken = default);

/// <summary>
/// Fetches all pages and returns them grouped in a list.
Expand Down
4 changes: 2 additions & 2 deletions SpotifyAPI.Web/Clients/SpotifyClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,9 @@ public SpotifyClient(SpotifyClientConfig config)
/// <param name="paginator">Optional. If not supplied, DefaultPaginator will be used</param>
/// <typeparam name="T">The Paging-Type</typeparam>
/// <returns>A list containing all fetched pages</returns>
public Task<IList<T>> PaginateAll<T>(IPaginatable<T> firstPage, IPaginator? paginator = null)
public Task<IList<T>> PaginateAll<T>(IPaginatable<T> firstPage, IPaginator? paginator = null, CancellationToken cancellationToken = default)
{
return (paginator ?? DefaultPaginator).PaginateAll(firstPage, _apiConnector);
return (paginator ?? DefaultPaginator).PaginateAll(firstPage, _apiConnector, cancellationToken);
}

/// <summary>
Expand Down