Repository navigation
Implement MetaPathFinder.find_spec method in MyFinder subclass - #2847
Closed
fumoboy007 wants to merge 1 commit into
Closed
fumoboy007 wants to merge 1 commit into
fumoboy007 wants to merge 1 commit into
Conversation
The `MyFinder` subclass of [`MetaPathFinder`](https://docs.python.org/3.11/library/importlib.html#importlib.abc.MetaPathFinder) currently only implements the deprecated `find_module` method. That deprecated method was [removed](python/cpython#98059) in Python 3.12. This change adds an implementation for its replacement method called `find_spec`.
Contributor
|
Merged, thanks for the fix! Sorry it took so long. |
Contributor
|
Merged. Thanks for noticing and contributing the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
MyFindersubclass ofMetaPathFindercurrently only implements the deprecatedfind_modulemethod. That deprecated method was removed in Python 3.12. This change adds an implementation for its replacement method calledfind_spec.