IllegalStateException: SkiaLayer is disposed - in 1.0.0-rc2 #1448

Activity

1. kirill-grouchnikov commented on Nov 23, 2021

   

   Kirill Grouchnikov (kirill-grouchnikov)

   on Nov 23, 2021

   Author

   More actions

   Reproducer:

   import androidx.compose.foundation.background
   import androidx.compose.foundation.clickable
   import androidx.compose.foundation.layout.Box
   import androidx.compose.foundation.layout.fillMaxSize
   import androidx.compose.foundation.layout.size
   import androidx.compose.ui.Modifier
   import androidx.compose.ui.awt.ComposeWindow
   import androidx.compose.ui.graphics.Color
   import androidx.compose.ui.unit.dp
   import androidx.compose.ui.window.Window
   import androidx.compose.ui.window.application
   import java.awt.Rectangle
   
   fun main() = application {
       Window(onCloseRequest = ::exitApplication, title = "Demo") {
           Box(modifier = Modifier.size(100.dp).background(Color.Red).clickable {
               val popupContentWindow = ComposeWindow()
               popupContentWindow.focusableWindowState = false
               popupContentWindow.type = java.awt.Window.Type.POPUP
               popupContentWindow.isAlwaysOnTop = true
               popupContentWindow.isUndecorated = true
               popupContentWindow.isResizable = false
   
               popupContentWindow.bounds = Rectangle(600, 400, 200, 200)
               popupContentWindow.setContent {
                   Box(modifier = Modifier.fillMaxSize().background(Color.Blue).clickable {
                       popupContentWindow.isVisible = false
                       popupContentWindow.dispose()
                   })
               }
   
               popupContentWindow.invalidate()
               popupContentWindow.validate()
               popupContentWindow.isVisible = true
           })
       }
   }
   
2. kirill-grouchnikov commented on Nov 23, 2021

   

   Kirill Grouchnikov (kirill-grouchnikov)

   on Nov 23, 2021

   Author

   More actions

   Click on the red square in the window. That creates a ComposeWindow with a blue box. Click that box to close the "popup" window and observe the stack trace
3. Igor Demin (igordmn)

   self-assigned this

   on Nov 23, 2021
4. Igor Demin (igordmn)

   added

   crash

   desktop

   window management

   on Nov 23, 2021
5. Igor Demin (igordmn)

   added this to the 1.0 milestone on Nov 23, 2021
6. kirill-grouchnikov commented on Nov 23, 2021

   

   Kirill Grouchnikov (kirill-grouchnikov)

   on Nov 23, 2021

   Author

   More actions

   Same in rc3
7. Igor Demin (igordmn)

   added

   p:criticalCritical priorityCritical priority

   on Nov 23, 2021
8. Igor Demin (igordmn)

   added a commit that references this issue on Nov 23, 2021

   Fix disposing window in event callback

   ...

   9ab1701
9. akurasov

   added

   wait for build

   on Nov 24, 2021
10. kirill-grouchnikov commented on Nov 25, 2021

    

    Kirill Grouchnikov (kirill-grouchnikov)

    on Nov 25, 2021

    Author

    More actions

    In 1.0.0-rc4 I now have this:

    Exception in thread "AWT-EventQueue-0" java.lang.IllegalStateException: ComposeScene is closed
    	at androidx.compose.ui.ComposeScene.sendPointerEvent-Kr8mkKM(ComposeScene.skiko.kt:402)
    	at androidx.compose.ui.ComposeScene.sendPointerEvent-Kr8mkKM$default(ComposeScene.skiko.kt:392)
    	at androidx.compose.ui.awt.ComposeLayer_desktopKt.onMouseEvent(ComposeLayer.desktop.kt:353)
    	at androidx.compose.ui.awt.ComposeLayer_desktopKt.access$onMouseEvent(ComposeLayer.desktop.kt:1)
    	at androidx.compose.ui.awt.ComposeLayer$onMouseEvent$1.invoke(ComposeLayer.desktop.kt:279)
    	at androidx.compose.ui.awt.ComposeLayer$onMouseEvent$1.invoke(ComposeLayer.desktop.kt:278)
    	at androidx.compose.ui.awt.ComposeLayer.catchExceptions(ComposeLayer.desktop.kt:88)
    	at androidx.compose.ui.awt.ComposeLayer.onMouseEvent(ComposeLayer.desktop.kt:278)
    	at androidx.compose.ui.awt.ComposeLayer.access$onMouseEvent(ComposeLayer.desktop.kt:69)
    	at androidx.compose.ui.awt.ComposeLayer$4.mouseMoved(ComposeLayer.desktop.kt:261)
    	at java.desktop/java.awt.AWTEventMulticaster.mouseMoved(AWTEventMulticaster.java:337)
    	at java.desktop/java.awt.Component.processMouseMotionEvent(Component.java:6677)
    	at java.desktop/java.awt.Component.processEvent(Component.java:6401)
    	at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:5008)
    	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4840)
    	at androidx.compose.ui.awt.ComposeLayer$ComponentImpl$scheduleSyntheticMoveEvent$1.run(ComposeLayer.desktop.kt:211)
    	at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:313)
    	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:770)
    	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
    	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
    	at java.base/java.security.AccessController.doPrivileged(Native Method)
    	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
    	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:740)
    	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
    	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
    	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
    	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
    	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
    	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)
    
11. kirill-grouchnikov commented on Nov 25, 2021

    

    Kirill Grouchnikov (kirill-grouchnikov)

    on Nov 25, 2021

    Author

    More actions

    Same demo. It doesn't happen every time the blue box in a popup window is clicked to close it, but happens frequently enough if you keep on clicking the red and then the blue
12. Igor Demin (igordmn)

    added a commit that references this issue on Nov 25, 2021

    Fix crash when AWT event is sent after the window is disposed

    ...

    2ec1417
13. igordmn commented on Nov 26, 2021

    

    Igor Demin (igordmn)

    on Nov 26, 2021

    Contributor

    More actions

    Should be fixed in 1.0.0-rc5. Thanks for the reports :)
14. Igor Demin (igordmn)

    closed this as completedon Nov 26, 2021
15. kirill-grouchnikov commented on Nov 26, 2021

    

    Kirill Grouchnikov (kirill-grouchnikov)

    on Nov 26, 2021

    Author

    More actions

    Confirming the fixes in rc5
16. Igor Demin (igordmn)

    added 5 commits that reference this issue on Jan 14, 2022

    Events

    ...

    0593438

    Get rid of async

    ...

    69725b2

    Desktop. Remove scheduling events on the next event loop frame

    ...

    1c08b7f

    Desktop. Remove scheduling events on the next event loop frame

    ...

    c4ad787

    Desktop. Fix crash when we close the window inside an event handler

    ...

    793ca65
17. copybara-service

    added 2 commits that reference this issue on Feb 1, 2022

    Desktop. Remove scheduling events on the next event loop frame

    ...

    0a818ac

    Desktop. Fix crash when we close the window inside an event handler

    ...

    8eb64bf
18. okushnikov commented on Jul 14, 2024

    

    okushnikov

    on Jul 14, 2024

    More actions

    Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.
19. JetBrains

    locked and limited conversation to collaborators on Dec 18, 2024
20. Zahari Zahariev (harryzz)

    added 2 commits that reference this issue on Jul 28, 2026

    Desktop. Remove scheduling events on the next event loop frame

    ...

    9d6fbe1

    Desktop. Fix crash when we close the window inside an event handler

    ...

    b9b1ebb