Skip to content

Render empty whereIn as 1 = 2 #35

Closed

Description

@JanHolger

Is your feature request related to a problem? Please describe.
Currently an empty whereIn clause will render as empty list which results in a MySQL error.

Describe the solution you'd like
An empty whereIn clause should render as 1 = 2 or some other false statement in order to replicate the expected behavior of WHERE x IN ()

Describe alternatives you've considered
Excluding the statement is another option but that's dangerous as sensitive data might be exposed that otherwise would have been filtered by the IN clause and doesn't really match the expected behavior of does the set () include element x.

Activity

  1. added a commit that references this issue on May 1, 2022
  2. JanHolger commented on May 1, 2022

    @JanHolger
    MemberAuthor

    Fixed in 1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions