Skip to content

fixed Yuri Urentsov #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
byte-yu wants to merge 2 commits into from
Closed

fixed Yuri Urentsov #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
511d7d1
fixed
byte-yu Sep 16, 2020
9eaeb54
Palindrome realization from lecture
byte-yu Sep 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lecture01/src/main/java/io/github/javaasasecondlanguage/lecture01/practice1/HelloWorld.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

public class HelloWorld {
public String getHelloWorld() {
return "Fix this string to pass tests";
return "Hello, World!";
}
}
8 changes: 6 additions & 2 deletions lecture01/src/main/java/io/github/javaasasecondlanguage/lecture01/practice2/Palindrome.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ public class Palindrome {
* 4. "abA" is not a palindrome.
* @throws IllegalArgumentException if str is `null`
*/
public static boolean isPalindrome(String str) {
throw new RuntimeException("Not implemented");
public static boolean isPalindrome(final String str) {
if (str == null) {
throw new IllegalArgumentException();
}

return str.equals((new StringBuilder(str)).reverse().toString());
}
}
2 changes: 1 addition & 1 deletion ...e01/src/test/java/io/github/javaasasecondlanguage/lecture01/practice1/HelloWorldTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import static org.junit.jupiter.api.Assertions.assertEquals;


@Disabled
//@Disabled
class HelloWorldTest {

@Test
Expand Down
2 changes: 1 addition & 1 deletion ...e01/src/test/java/io/github/javaasasecondlanguage/lecture01/practice2/PalindromeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import static org.junit.jupiter.api.Assertions.*;

@Disabled
//@Disabled
class PalindromeTest {
@Test
void nullIsAnIlligalArgument() {
Expand Down