Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
minleejae
marked this pull request as ready for review
October 1, 2026 15:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ForeignKeyIndex now delegates to ForeignKeyReference instead of maintaining a second table, column list and action set. This preserves action identity and ON DELETE target columns when inspecting the reference. Removing a mutated referential action also works after its hash changes.
Existing parser result classes and public method signatures are retained. This change does not expand grammar or dialect acceptance. setReference(null) retains current legacy table/columns/actions while dropping reference-only options; it no longer restores stale snapshots.
Validation: Four of 8 new regressions fail on the base. All 366 focused CREATE/ALTER/foreign-key tests pass, plus Spotless.
Combined validation with the six related DDL refactoring branches: Gradle check passes (9,395 tests: 9,370 passed, 25 skipped, zero failures). Of 840 DDL cases accepted by MySQL 8.4.11/PostgreSQL 18.6, 835 parse and produce toString/deparser SQL that also executes successfully; the remaining 5 already fail to parse on base 87e8814. Final SQL outputs match the DB-replayed outputs exactly. These combined checks supplement the branch-specific tests above.