Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Signed-off-by: minleejae <mmj9808@gmail.com>
minleejae
marked this pull request as ready for review
October 1, 2026 15:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After parsing PARTITION BY, legacy setters previously changed snapshots that rendering ignored. Delegate type, expression, columns and definitions to TablePartitioning, expose mutable column-name views, preserve quoted identifiers, and clear stale data when replacing or removing the structured clause.
Existing parser result classes and public method signatures are retained. This change does not expand grammar or dialect acceptance. setPartitioning(null) clears the structured clause instead of restoring stale snapshots. The legacy name-list getter is mutable; assigned names become structured Column nodes.
Validation: All 9 initial regression tests fail on the base. 314 related tests pass; the quoted-identifier follow-up passes 35 tests. Spotless, Checkstyle, PMD and SpotBugs passed for the initial change.
Combined validation with the six related DDL refactoring branches: Gradle check passes (9,395 tests: 9,370 passed, 25 skipped, zero failures). Of 840 DDL cases accepted by MySQL 8.4.11/PostgreSQL 18.6, 835 parse and produce toString/deparser SQL that also executes successfully; the remaining 5 already fail to parse on base 87e8814. Final SQL outputs match the DB-replayed outputs exactly. These combined checks supplement the branch-specific tests above.