Skip to content

Fix Rails 8.2 deprecation warnings and improve Rack compatibility #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
takaokouji wants to merge 30 commits into from
Closed

Fix Rails 8.2 deprecation warnings and improve Rack compatibility #1483

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
f0342fd
Add log/*.log to .gitignore and remove development.log
koji-takao-sp Nov 1, 2025
77c9da2
Add comprehensive coverage measurement with SimpleCov
koji-takao-sp Oct 31, 2025
29e4e4f
Add Rails 7.1 compatibility (partial - 664/674 tests passing)
koji-takao-sp Oct 31, 2025
e2f6441
Complete Rails 7.1.6 support with Rack 3.0 compatibility
koji-takao-sp Oct 31, 2025
cda51a6
Complete Rails 7.2.3 support
koji-takao-sp Nov 1, 2025
de5dfea
Complete Rails 8.0.4 support
koji-takao-sp Nov 1, 2025
d277fc4
Add partial Rails 8.1.2 support (664/674 tests passing)
koji-takao-sp Nov 1, 2025
85d6cce
Add complete Rails 8.1.2 support
koji-takao-sp Nov 1, 2025
88e01a4
Fix Rails 5.2-6.1 compatibility in test_helper.rb
koji-takao-sp Jan 20, 2026
93cf21f
Sync test_helper.rb compatibility fixes from docker-support
koji-takao-sp Jan 20, 2026
878520c
Add Logger require for Ruby 2.6 compatibility
koji-takao-sp Jan 20, 2026
01bdcd4
Fix unstable ordering in BookCommentResource for PostgreSQL
koji-takao-sp Jan 20, 2026
0914344
Fix test_warn_on_joined_to_many for Ruby 2.7 with Rails 5.2
koji-takao-sp Jan 20, 2026
2c4e452
Fix unstable ordering in Book associations for PostgreSQL
koji-takao-sp Jan 20, 2026
013f87a
Update CI matrix for Ruby 3.3, 3.4 and Rails 6.1-8.1
koji-takao-sp Jan 20, 2026
ae2e6af
Add csv gem dependency for Ruby 3.4+ support
koji-takao-sp Jan 20, 2026
dbb5e1a
Add default_scope to BookComment for stable ordering
koji-takao-sp Jan 20, 2026
7a7b80e
Merge pull request #9 from speee/rails-8.1-support-core
koji-takao-sp Jan 20, 2026
3fbf28b
Add Docker support for multi-version Rails testing
koji-takao-sp Jan 20, 2026
9783d74
Add Docker services for Rails 7.1-8.1 testing
koji-takao-sp Jan 20, 2026
d51c6dd
Fix Docker command to remove Gemfile.lock before bundle install
koji-takao-sp Jan 20, 2026
d4203e2
Add SQLite WAL mode files to .gitignore
koji-takao-sp Jan 20, 2026
5ff7f95
Add Docker services for Rails 5.1, 5.2, and 6.0
koji-takao-sp Jan 20, 2026
74294a5
Add Ruby 2.7 Dockerfile for Rails 5.1-6.0 compatibility
koji-takao-sp Jan 20, 2026
44f9266
Fix bundler version for Ruby 2.7 compatibility
koji-takao-sp Jan 20, 2026
5c90b83
Fix Psych::DisallowedClass error for Rails 6.0 with Ruby 2.7+
koji-takao-sp Jan 20, 2026
d78b012
Change Rails 6.1-8.1 to use Ruby 3.1.5
koji-takao-sp Jan 20, 2026
49d75c6
Use Ruby 3.1.5 for Rails 6.1-7.2, Ruby 3.4 for Rails 8.0-8.1
koji-takao-sp Jan 20, 2026
37bad60
Merge pull request #10 from speee/docker-support-speee
koji-takao-sp Jan 20, 2026
005a426
Fix Rails 8.2 deprecation warnings and improve Rack compatibility
koji-takao-sp Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test_warn_on_joined_to_many for Ruby 2.7 with Rails 5.2 
The test was failing on Ruby 2.7 with Rails 5.2.8.1 because ActiveRecord
deprecation warnings were appearing in stderr alongside the expected
performance warning, causing the exact string match assertion to fail.

Changes:
- Replace assert_equal with assert_match to check for presence of the
  performance warning rather than exact stderr match
- Replace assert_empty with refute_match to verify the performance
  warning doesn't appear when disabled, while tolerating environment-
  specific deprecation warnings

This makes the test more robust across different Ruby/Rails versions
while still validating the core functionality.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
  • Loading branch information
@koji-takao-sp @claude
koji-takao-sp and claude committed Jan 20, 2026
commit 09143441e618008076f1c789f0d13c120418628a
6 changes: 4 additions & 2 deletions test/controllers/controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3682,14 +3682,16 @@ def test_warn_on_joined_to_many
get :index, params: {fields: {posts: 'id,title'}}
assert_response :success
end
assert_equal(err, "Performance issue detected: `Api::V4::PostResource.records` returned non-normalized results in `Api::V4::PostResource.find_fragments`.\n")
assert_match(/Performance issue detected: `Api::V4::PostResource.records` returned non-normalized results in `Api::V4::PostResource.find_fragments`\./, err)

JSONAPI.configuration.warn_on_performance_issues = false
_out, err = capture_subprocess_io do
get :index, params: {fields: {posts: 'id,title'}}
assert_response :success
end
assert_empty err
# On older Ruby/Rails combinations, there may be deprecation warnings
# but we should not see the performance issue warning
refute_match(/Performance issue detected/, err)

ensure
JSONAPI.configuration = original_config
Expand Down
Loading