Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Re-implement DataFrame unboxing #860

Merged
densmirn merged 13 commits into from
May 29, 2020
Merged

Re-implement DataFrame unboxing #860

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4e5cd9a
Boxing draft
akharche May 25, 2020
06e9295
Merge branch 'feature/dataframe_model_refactoring' of https://github.…
akharche May 27, 2020
ce499ff
Implement unboxing in new structure
akharche May 27, 2020
fdf672e
Improve variable names + add error handling
akharche May 28, 2020
f164c3d
Return error status
akharche May 28, 2020
99e9269
Move getting list size to if_ok block
akharche May 28, 2020
ce771b8
Unskipped unexpected success tests
akharche May 28, 2020
6b45a77
Unskipped unexpected success tests in GroupBy
akharche May 28, 2020
0814cc3
Merge branch 'feature/dataframe_model_refactoring' of https://github.…
akharche May 29, 2020
66b40a8
Remove decorators
akharche May 29, 2020
1d43ce6
Change to incref False
akharche May 29, 2020
8ee9364
Skip tests failed due to unimplemented df structure
akharche May 29, 2020
666fceb
Bug in rolling
akharche May 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change to incref False
  • Loading branch information
@akharche
akharche committed May 29, 2020
commit 1d43ce678964eabf26a56d9d5be6329e7c8bb8ff
4 changes: 2 additions & 2 deletions sdc/hiframes/boxing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def unbox_dataframe(typ, val, c):
with if_ok:
inst.size = c.context.get_constant(types.intp, n_cols)
for i, column_str in enumerate(column_strs):
inst.setitem(c.context.get_constant(types.intp, i), column_str, incref=True)
inst.setitem(c.context.get_constant(types.intp, i), column_str, incref=False)
dataframe.columns = inst.value

with if_not_ok:
Expand Down Expand Up @@ -129,7 +129,7 @@ def unbox_dataframe(typ, val, c):
elif ty_series == string_array_type:
native_val = unbox_str_series(string_array_type, series_obj, c)

inst.setitem(c.context.get_constant(types.intp, i), native_val.value, incref=True)
inst.setitem(c.context.get_constant(types.intp, i), native_val.value, incref=False)

dataframe.data = c.builder.insert_value(dataframe.data, inst.value, type_id)

Expand Down
1 change: 1 addition & 0 deletions sdc/tests/test_dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -970,6 +970,7 @@ def test_impl():
sdc_func = sdc.jit(test_impl)
pd.testing.assert_frame_equal(sdc_func(), test_impl())

@unittest.skip('DF with column named "bool" Segmentation fault')
def test_df_bool(self):
def test_impl(df):
return df.isna()
Expand Down