Skip to content

Implement asynchronous fill method using dpctl kernels #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonwolfy merged 26 commits into from
Oct 25, 2024
Merged

Implement asynchronous fill method using dpctl kernels #2055

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
f955945
Enhance `dpnp_array.fill` method
ndgrigorian Sep 17, 2024
13edd84
Fix missing disclaimer in dpnp_arraycreation.py
ndgrigorian Sep 17, 2024
4976a24
Import `dpnp_array` directly
ndgrigorian Sep 17, 2024
978a081
Skip `test_fill_with_numpy_scalar_ndarray`
ndgrigorian Sep 17, 2024
2686af9
Add dependencies to zeros and full kernels in `dpnp_fill`
ndgrigorian Sep 18, 2024
2a826b2
Remove redundant validation of first `dpnp_fill` argument
ndgrigorian Sep 18, 2024
6e2193b
Improve `dpnp_fill` array/scalar path logic
ndgrigorian Sep 18, 2024
08b6c26
Disallow inputs to `dpnp_fill` on separate queues
ndgrigorian Sep 18, 2024
c64dc0b
Adjust skip message for `test_fill_with_numpy_scalar_ndarray`
ndgrigorian Oct 14, 2024
9691cf0
Tweak error messages in `dpnp_fill`
ndgrigorian Oct 14, 2024
957b93a
Add tests for new `fill` method
ndgrigorian Oct 14, 2024
87e6560
Update docstring for `fill` method
ndgrigorian Oct 14, 2024
985b4fa
Fix pre-commit in cupy fill tests
ndgrigorian Oct 14, 2024
d8a3e65
Change `asarray` to `astype` in `dpnp_fill`
ndgrigorian Oct 22, 2024
70618e1
Expand TEST_SCOPE to include `test_fill.py`
ndgrigorian Oct 22, 2024
478397f
Remove redundant check from `dpnp_fill`
ndgrigorian Oct 22, 2024
f782d1c
Use `_cast_fill_val` private function from `dpctl.tensor._ctors`
ndgrigorian Oct 22, 2024
e29685e
Add tests per PR review by @antonwolfy
ndgrigorian Oct 22, 2024
bd30f85
Improve validation of `val` for `fill` method
ndgrigorian Oct 23, 2024
865867a
Add to permit NumPy bools as `dpnp_fill` scalar fill values
ndgrigorian Oct 24, 2024
4ba7186
Use `dpnp.bool` in `dpnp_fill` and make `isinstance` check more effic…
ndgrigorian Oct 24, 2024
48c8051
Replace branching for `fill` scalar type with `_cast_fill_value`
ndgrigorian Oct 24, 2024
8adc06a
Add additional tests for `fill`
ndgrigorian Oct 24, 2024
c91ab47
Merge branch 'master' into implement-efficient-fill-method
antonwolfy Oct 24, 2024
c4e0481
Merge branch 'master' into implement-efficient-fill-method
ndgrigorian Oct 24, 2024
387b542
Merge branch 'master' into implement-efficient-fill-method
ndgrigorian Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Expand TEST_SCOPE to include test_fill.py
  • Loading branch information
@ndgrigorian
ndgrigorian committed Oct 22, 2024
commit 70618e1f9c7c2659cacc9ae116d575aaeb0921f2
1 change: 1 addition & 0 deletions .github/workflows/conda-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ env:
test_copy.py
test_counting.py
test_fft.py
test_fill.py
test_flat.py
test_histogram.py
test_indexing.py
Expand Down