Skip to content

Add missing device info queries #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndgrigorian merged 14 commits into from
Aug 6, 2026
+2,190 −52
Merged

Add missing device info queries #2324

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2cdd2ed
add missing device info queries
ndgrigorian Jun 12, 2026
0ca163f
add missing enums to docs
ndgrigorian Aug 3, 2026
4d65de0
Fix missing validation of returned enums
ndgrigorian Aug 3, 2026
9f7a28f
use array deletion utilities in new C++ tests
ndgrigorian Aug 3, 2026
7e10097
remove deletion instruction from docstring
ndgrigorian Aug 3, 2026
38b62bf
add null tests for new APIs
ndgrigorian Aug 3, 2026
559c9e5
fix __dpctl_keep to __dpctl_give where appropriate
ndgrigorian Aug 4, 2026
4995e84
fixed functions mislabeled with __dpctl_keep
ndgrigorian Aug 4, 2026
a42d4d8
clean up condition for indeterminate global mem cache type
ndgrigorian Aug 4, 2026
9f97294
fix tautology in get max samplers test
ndgrigorian Aug 4, 2026
587a169
fix remaining tautologies in tests
ndgrigorian Aug 4, 2026
75030b5
docstring fixes
ndgrigorian Aug 4, 2026
e06af59
add sentinel values for enums and remove duplication
ndgrigorian Aug 5, 2026
b7661fe
add gh-2324 to changelog
ndgrigorian Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docstring fixes
  • Loading branch information
@ndgrigorian
ndgrigorian committed Aug 4, 2026
commit 75030b54b733af1e19f19759df0f882a9e496c75
10 changes: 9 additions & 1 deletion dpctl/_sycl_device.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2273,6 +2273,10 @@ cdef class SyclDevice(_SyclDevice):
Returns:
Comment thread
ndgrigorian marked this conversation as resolved.
Resolved
str:
The device version string.

Raises:
RuntimeError:
If the ``version`` descriptor is not available.
"""
cdef const char *ver = DPCTLDevice_GetVersion(self._device_ref)
if ver is NULL:
Expand All @@ -2283,11 +2287,15 @@ cdef class SyclDevice(_SyclDevice):

@property
def backend_version(self):
""" Returns a backend-defined driver version string.
""" Returns a backend version string.

Returns:
Comment thread
ndgrigorian marked this conversation as resolved.
Resolved
str:
The backend version string.

Raises:
RuntimeError:
If the ``backend_version`` descriptor is not available.
"""
cdef const char *ver = DPCTLDevice_GetBackendVersion(self._device_ref)
if ver is NULL:
Expand Down
Loading