Skip to content

Disallow scalar conversation for non-0D arrays #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndgrigorian merged 7 commits into from
Jan 13, 2026
Merged

Disallow scalar conversation for non-0D arrays #2223

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
96c722c
Disallow numeric scalar conversion for non-0d arrays
vlad-perevezentsev Dec 22, 2025
33b2c8d
Update scalar conversion tests for non-0d arrays
vlad-perevezentsev Dec 22, 2025
da2598c
Avoid in-place modification of ndarray.shape in TestCopyScalar
vlad-perevezentsev Dec 23, 2025
2d4ad51
Disallow bool scalar conversation and update tests
vlad-perevezentsev Dec 24, 2025
239e5b1
Merge master into disallow_conv_to_scalar_ndim
vlad-perevezentsev Dec 24, 2025
ce0dadb
Use asnumpy().all() in tests to avoid additional kernel launches
vlad-perevezentsev Jan 9, 2026
5f28594
Update changelog
vlad-perevezentsev Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use asnumpy().all() in tests to avoid additional kernel launches
  • Loading branch information
@vlad-perevezentsev
vlad-perevezentsev committed Jan 9, 2026
commit ce0dadb65a2b86d13695de72b796ec61f023b0b9
4 changes: 2 additions & 2 deletions dpctl/tests/test_usm_ndarray_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1435,7 +1435,7 @@ def test_nonzero_f_contig():

for exp, res in zip(expected_res, result):
assert_array_equal(dpt.asnumpy(res), exp)
assert dpt.all(mask[result])
assert dpt.asnumpy(mask[result]).all()


def test_nonzero_compacting():
Expand All @@ -1454,7 +1454,7 @@ def test_nonzero_compacting():

for exp, res in zip(expected_res, result):
assert_array_equal(dpt.asnumpy(res), exp)
assert dpt.all(mask_view[result])
assert dpt.asnumpy(mask_view[result]).all()


def test_assign_scalar():
Expand Down
14 changes: 7 additions & 7 deletions dpctl/tests/test_usm_ndarray_operators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,14 +129,14 @@ def test_mat_ops(namespace):
@pytest.mark.parametrize("namespace", [dpt, Dummy()])
def test_comp_ops(namespace):
try:
X = dpt.ones(1, dtype="u8")
X = dpt.asarray(1, dtype="u8")
except dpctl.SyclDeviceCreationError:
pytest.skip("No SYCL devices available")
X._set_namespace(namespace)
assert X.__array_namespace__() is namespace
assert dpt.all(X.__gt__(-1))
assert dpt.all(X.__ge__(-1))
assert not dpt.all(X.__lt__(-1))
assert not dpt.all(X.__le__(-1))
assert not dpt.all(X.__eq__(-1))
assert dpt.all(X.__ne__(-1))
assert X.__gt__(-1)
assert X.__ge__(-1)
assert not X.__lt__(-1)
assert not X.__le__(-1)
assert not X.__eq__(-1)
assert X.__ne__(-1)
10 changes: 5 additions & 5 deletions dpctl/tests/test_usm_ndarray_sorting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,11 +354,11 @@ def test_radix_sort_size_1_axis():

x3 = dpt.reshape(dpt.arange(10, dtype="i1"), (10, 1))
r3 = dpt.sort(x3, kind="radixsort")
assert dpt.all(r3 == x3)
assert dpt.asnumpy(r3 == x3).all()

x4 = dpt.reshape(dpt.arange(10, dtype="i1"), (1, 10))
r4 = dpt.sort(x4, axis=0, kind="radixsort")
assert dpt.all(r4 == x4)
assert dpt.asnumpy(r4 == x4).all()


def test_radix_argsort_size_1_axis():
Expand All @@ -370,12 +370,12 @@ def test_radix_argsort_size_1_axis():

x2 = dpt.ones([1], dtype="i1")
r2 = dpt.argsort(x2, kind="radixsort")
assert dpt.all(r2 == 0)
assert dpt.asnumpy(r2 == 0).all()

x3 = dpt.reshape(dpt.arange(10, dtype="i1"), (10, 1))
r3 = dpt.argsort(x3, kind="radixsort")
assert dpt.all(r3 == 0)
assert dpt.asnumpy(r3 == 0).all()

x4 = dpt.reshape(dpt.arange(10, dtype="i1"), (1, 10))
r4 = dpt.argsort(x4, axis=0, kind="radixsort")
assert dpt.all(r4 == 0)
assert dpt.asnumpy(r4 == 0).all()
Loading