Skip to content

Remove use of python setup.py develop/install in the project #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndgrigorian merged 23 commits into from
Nov 21, 2025
Merged

Remove use of python setup.py develop/install in the project #2172

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
164ba83
update build_locally script to avoid python setup.py develop call
ndgrigorian Oct 14, 2025
2e96092
refactor common build functionality out into separate file
ndgrigorian Oct 15, 2025
07590f7
remove --build-dir option and fix --clean option
ndgrigorian Oct 15, 2025
5b0bd76
do not return compiler root unnecessarily from resolve_compilers
ndgrigorian Oct 15, 2025
6ab378b
update gen_coverage script to align with build_locally
ndgrigorian Oct 21, 2025
df44252
resolve bin_llvm from default compiler layout when not provided
ndgrigorian Oct 28, 2025
23aad14
keep find_objects defined within main
ndgrigorian Oct 28, 2025
6ac779e
generalize err and warn utilities for different build scripts
ndgrigorian Oct 28, 2025
bfd5891
use common resolve_compilers utility
ndgrigorian Oct 28, 2025
a54e341
update gen_docs script
ndgrigorian Oct 28, 2025
0738341
try using pip install -e in place of setup.py develop in CI
ndgrigorian Oct 28, 2025
b84cdf8
use python setup.py build_ext in Cython extension building
ndgrigorian Oct 28, 2025
e675ff1
add types and descriptions for script args
ndgrigorian Oct 30, 2025
8ce292f
do not override CMAKE_ARGS in build scripts
ndgrigorian Oct 30, 2025
6b62a8e
fix typo in cmake arg
ndgrigorian Oct 30, 2025
8bfa41c
remove `--target-level-zero argument`
ndgrigorian Nov 5, 2025
ec29c49
raise RuntimeError from scripts with invalid arguments
ndgrigorian Nov 5, 2025
b0bbfb3
Update CONTRIBUTING.md
ndgrigorian Nov 6, 2025
17a09fc
Update docs and example build instructions to remove python setup.py …
ndgrigorian Nov 6, 2025
ab77357
remove adding scripts to sys.path
ndgrigorian Nov 6, 2025
82ea6d7
Use updated build scripts in CI
ndgrigorian Nov 6, 2025
d5f25cf
Merge pull request #2189 from IntelPython/use-build-scripts-in-public-ci
ndgrigorian Nov 6, 2025
7962541
address review comments
ndgrigorian Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
raise RuntimeError from scripts with invalid arguments 
slips in changes to `clean_build_dir`
  • Loading branch information
@ndgrigorian
ndgrigorian committed Nov 6, 2025
commit ec29c49fea4826d3ed040cecdc4bf55c6d348d70
18 changes: 14 additions & 4 deletions scripts/_build_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def capture_cmd_output(cmd: list[str], cwd: str = None):


def err(msg: str, script: str):
print(f"[{script}][error] {msg}", file=sys.stderr)
raise RuntimeError(f"[{script}] error: {msg}")


def log_cmake_args(cmake_args: list[str], script: str):
Expand Down Expand Up @@ -150,8 +150,18 @@ def install_editable(setup_dir: str, env: dict[str, str]):
)


def clean_build_dir(setup_dir: str = None):
or os.getcwd(), "_skbuild")
def clean_build_dir(setup_dir: str):
if (
not isinstance(setup_dir, str)
or not setup_dir
or not os.path.isdir(setup_dir)
):
raise RuntimeError(f"Invalid setup directory provided: '{setup_dir}'")
"_skbuild")
if os.path.exists(target):
print(f"Cleaning build directory: {target}")
shutil.rmtree(target)
try:
shutil.rmtree(target)
except Exception as e:
print(f"Failed to remove build directory: '{target}'")
raise e