Skip to content

Resolve gh-2055 #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndgrigorian merged 6 commits into from
Apr 24, 2025
Merged

Resolve gh-2055 #2058

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
346eedd
Resolve `dpt.asarray` failed to copy input `numpy.ndarray` #2055
ndgrigorian Apr 17, 2025
5442d79
Adjust docstrings in `_copy_utils`
ndgrigorian Apr 21, 2025
d73cddd
Add test for gh-2055 resolution and refactor tests for _copy_utils in…
ndgrigorian Apr 21, 2025
eafb644
factor common call out of logic in _asarray_from_numpy_ndarray
ndgrigorian Apr 23, 2025
5b4ae4a
np.ndarray->numpy.ndarray in error text
ndgrigorian Apr 23, 2025
152a3ed
change variable names throughout _copy_utils
ndgrigorian Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
factor common call out of logic in _asarray_from_numpy_ndarray
  • Loading branch information
@ndgrigorian
ndgrigorian committed Apr 23, 2025
commit eafb644f1301fc6d28b714ae85078385fe3fdf9a
3 changes: 1 addition & 2 deletions dpctl/tensor/_ctors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,7 @@ def _asarray_from_numpy_ndarray(
if dtype is None:
# deduce device-representable output data type
dtype = _map_to_device_dtype(ary.dtype, copy_q)
_ensure_native_dtype_device_support(dtype, copy_q.sycl_device)
f_contig = ary.flags["F"]
c_contig = ary.flags["C"]
fc_contig = f_contig or c_contig
Expand All @@ -245,10 +246,8 @@ def _asarray_from_numpy_ndarray(
order = "C" if c_contig else "F"
if order == "K":
# new USM allocation
_ensure_native_dtype_device_support(dtype, copy_q.sycl_device)
res = _from_numpy_empty_like_orderK(ary, dtype, usm_type, copy_q)
else:
_ensure_native_dtype_device_support(dtype, copy_q.sycl_device)
res = dpt.usm_ndarray(
ary.shape,
dtype=dtype,
Expand Down