Skip to content

Update integer advanced indexing for array API 2024.12 spec #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndgrigorian merged 13 commits into from
Apr 9, 2025
Merged

Update integer advanced indexing for array API 2024.12 spec #2032

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
87fa69a
Update integer advanced indexing for array API 2024
ndgrigorian Mar 26, 2025
47639da
only treat integers as arrays when arrays have been consecutive
ndgrigorian Mar 26, 2025
b18fe9d
raise for OOB indices even if they will be converted to arrays
ndgrigorian Mar 26, 2025
9a7705e
Add common utilities for _put_multi_index and _take_multi_index
ndgrigorian Apr 3, 2025
25fb1a2
Remove redundant IndexError in _slicing.pxi
ndgrigorian Apr 3, 2025
14a55d0
Fix over-indentation
ndgrigorian Apr 3, 2025
72f8938
Add tests for uncovered branches in advanced indexing
ndgrigorian Apr 3, 2025
b38478b
Add another test for advanced indexing
ndgrigorian Apr 8, 2025
d873f35
Add another test for advanced indexing errors
ndgrigorian Apr 8, 2025
0784d70
Partial reversion of advanced indexing changes
ndgrigorian Apr 9, 2025
682b598
Merge branch 'master' into update-indexing-for-array-api-2024
ndgrigorian Apr 9, 2025
87db03a
Use operator.index in _slicing.pxi
ndgrigorian Apr 9, 2025
2fdac4c
Adds a test that 0D integral indices are treated as Python scalars wh…
ndgrigorian Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Adds a test that 0D integral indices are treated as Python scalars wh… 
…en not among consecutive integer arrays
  • Loading branch information
@ndgrigorian
ndgrigorian committed Apr 9, 2025
commit 2fdac4cb555aa3c82f9a6d036076d3128bc7d9d0
11 changes: 11 additions & 0 deletions dpctl/tests/test_usm_ndarray_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,17 @@ def test_advanced_slice15():
x[ii, 0, ii, :, ii]


def test_advanced_slice16():
q = get_queue_or_skip()
ii = dpt.asarray(1, sycl_queue=q)
i0 = dpt.asarray(False, sycl_queue=q)
i1 = dpt.asarray(True, sycl_queue=q)
x = dpt.reshape(dpt.arange(3**5, dtype="i4", sycl_queue=q), (3,) * 5)
y = x[ii, i0, ii, i1, :]
# TODO: add a shape check here when discrepancy with NumPy is investigated
assert isinstance(y, dpt.usm_ndarray)


def test_boolean_indexing_validation():
get_queue_or_skip()
x = dpt.zeros(10, dtype="i4")
Expand Down