Skip to content

Add out keyword to dpt.take #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndgrigorian merged 7 commits into from
Mar 17, 2025
Merged

Add out keyword to dpt.take #2010

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
594785c
Add support for the `out` keyword in `tensor.take`
ndgrigorian Feb 21, 2025
1b38641
np.intp -> "i8" in indexing tests
ndgrigorian Mar 13, 2025
aca8aa0
Add tests for take with out keyword
ndgrigorian Mar 13, 2025
fb374cf
Formatting changes per PR review by @vtavana
ndgrigorian Mar 14, 2025
d8b3025
Clean up formatting in error handling in `take`
ndgrigorian Mar 14, 2025
29cf75b
Fix `take` signature in docstring
ndgrigorian Mar 14, 2025
6f7a653
Add gh-2010 to changelog
ndgrigorian Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Formatting changes per PR review by @vtavana
  • Loading branch information
@ndgrigorian
ndgrigorian committed Mar 17, 2025
commit fb374cf916f8bdddcc37ea9467d25c261a8c4267
10 changes: 2 additions & 8 deletions dpctl/tests/test_usm_ndarray_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1892,10 +1892,7 @@ def test_put_along_axis_uint64_indices():
assert dpt.all(expected == x)


@pytest.mark.parametrize(
"data_dt",
_all_dtypes,
)
@pytest.mark.parametrize("data_dt", _all_dtypes)
@pytest.mark.parametrize("order", ["C", "F"])
def test_take_out(data_dt, order):
q = get_queue_or_skip()
Expand All @@ -1914,10 +1911,7 @@ def test_take_out(data_dt, order):
assert dpt.all(out == expected)


@pytest.mark.parametrize(
"data_dt",
_all_dtypes,
)
@pytest.mark.parametrize("data_dt", _all_dtypes)
@pytest.mark.parametrize("order", ["C", "F"])
def test_take_out_overlap(data_dt, order):
q = get_queue_or_skip()
Expand Down