Skip to content

Backport gh-2002 #2004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndgrigorian merged 2 commits into from
Feb 20, 2025
Merged

Backport gh-2002 #2004

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
676075a
Fix memory leaks in synchronizing kernel calls
ndgrigorian Feb 20, 2025
fd47767
Add gh-2002 to 0.19.0 changelog
ndgrigorian Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix memory leaks in synchronizing kernel calls 
In synchronizing calls, smart pointers were being released (rather than reset)
with no call to free underlying memory, causing USM to leak
  • Loading branch information
@ndgrigorian
ndgrigorian committed Feb 20, 2025
commit 676075a3906483be002e3a5c84dee40539142262
8 changes: 4 additions & 4 deletions dpctl/tensor/libtensor/source/accumulators.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ std::size_t py_mask_positions(const dpctl::tensor::usm_ndarray &mask,
sycl::event::wait(host_task_events);

// ensure deleter of smart pointer is invoked with GIL released
shape_strides_owner.release();
shape_strides_owner.reset(nullptr);
}
throw std::runtime_error("Unexpected error");
}
Expand All @@ -231,7 +231,7 @@ std::size_t py_mask_positions(const dpctl::tensor::usm_ndarray &mask,

sycl::event::wait(host_task_events);
// ensure deleter of smart pointer is invoked with GIL released
shape_strides_owner.release();
shape_strides_owner.reset(nullptr);
}

return total_set;
Expand Down Expand Up @@ -367,7 +367,7 @@ std::size_t py_cumsum_1d(const dpctl::tensor::usm_ndarray &src,
sycl::event::wait(host_task_events);

// ensure USM deleter is called with GIL released
shape_strides_owner.release();
shape_strides_owner.reset(nullptr);
}
throw std::runtime_error("Unexpected error");
}
Expand All @@ -387,7 +387,7 @@ std::size_t py_cumsum_1d(const dpctl::tensor::usm_ndarray &src,
sycl::event::wait(host_task_events);

// ensure USM deleter is called with GIL released
shape_strides_owner.release();
shape_strides_owner.reset(nullptr);
}

return total;
Expand Down
2 changes: 1 addition & 1 deletion dpctl/tensor/libtensor/source/copy_numpy_ndarray_into_usm_ndarray.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ void copy_numpy_ndarray_into_usm_ndarray(
dst_offset, depends, {copy_shape_ev});

// invoke USM deleter in smart pointer while GIL is held
shape_strides_owner.release();
shape_strides_owner.reset(nullptr);
}

return;
Expand Down