Skip to content

Technical debt changes #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandr-pavlyk merged 11 commits into from
Jan 10, 2025
Merged

Technical debt changes #1957

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
620bdd0
Replace use of anonymous namespace in kernels/elementwise_functions h…
oleksandr-pavlyk Jan 8, 2025
87052e2
Replace use of anonymous namespace in headers
oleksandr-pavlyk Jan 8, 2025
869faef
Reduced number of created iota and map_back kernels
oleksandr-pavlyk Jan 8, 2025
80f288c
Move vectors ptrs and dels into host_task lambda
oleksandr-pavlyk Jan 8, 2025
08cfede
Moved local update kernels to separate function which take fewer temp…
oleksandr-pavlyk Jan 8, 2025
8c167bf
Add comment before call to unique_ptr::release method
oleksandr-pavlyk Jan 9, 2025
ce02c6c
Add comments explaining intention of unique_ptr::reset call
oleksandr-pavlyk Jan 9, 2025
fea54b6
Replace sycl::malloc_device with smart_malloc_device
oleksandr-pavlyk Jan 9, 2025
9841f9e
Change signature of copy_and_cast_from_host_impl and copy_for_reshape…
oleksandr-pavlyk Jan 9, 2025
9d77faf
Change to device_allocate_and_pack to return unique_ptr
oleksandr-pavlyk Jan 9, 2025
065413e
Merge _sorting_impl and _sorting_radix_impl modules
oleksandr-pavlyk Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comments explaining intention of unique_ptr::reset call
  • Loading branch information
@oleksandr-pavlyk
oleksandr-pavlyk committed Jan 9, 2025
commit ce02c6ceca7f4f5e873eee8f702c9356e9715f49
6 changes: 4 additions & 2 deletions dpctl/tensor/libtensor/include/kernels/accumulators.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1233,7 +1233,8 @@ std::size_t cumsum_val_contig_impl(sycl::queue &q,
copy_e.wait();
std::size_t return_val = static_cast<std::size_t>(*last_elem_host_usm);

// free USM host allocation
// explicitly free USM host allocation, by envoking deleter of
// the unique_ptr
host_usm_owner.reset(nullptr);
Comment thread
oleksandr-pavlyk marked this conversation as resolved.

return return_val;
Expand Down Expand Up @@ -1347,7 +1348,8 @@ cumsum_val_strided_impl(sycl::queue &q,
copy_e.wait();
std::size_t return_val = static_cast<std::size_t>(*last_elem_host_usm);

// free USM-host temporary
// explicitly free USM-host temporary, by envoking deleter of
// the unique_ptr
host_usm_owner.reset(nullptr);
Comment thread
oleksandr-pavlyk marked this conversation as resolved.

return return_val;
Expand Down