Skip to content

Backport gh1874 #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandr-pavlyk merged 5 commits into from
Nov 21, 2024
Merged

Backport gh1874 #1904

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6fd61c3
Correctly handle inputs which are all Python scalars (weak types)
oleksandr-pavlyk Oct 23, 2024
7fc36a6
Add test that result_types(dtypes) works the same for Python/NumPy sc…
oleksandr-pavlyk Oct 23, 2024
625e07a
Record chagne to result_type in CHANGELOG
oleksandr-pavlyk Oct 23, 2024
411dd2f
Changed test_result_type_bug_1874 to work with NumPy 2 and older on Win
oleksandr-pavlyk Oct 23, 2024
bf71ca1
Change link to PR from 1877 to 1904
oleksandr-pavlyk Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changed test_result_type_bug_1874 to work with NumPy 2 and older on Win
  • Loading branch information
@oleksandr-pavlyk
oleksandr-pavlyk committed Nov 21, 2024
commit 411dd2fdc62069783797d2bd0788315ab77cb8fd
8 changes: 6 additions & 2 deletions dpctl/tests/test_usm_ndarray_manipulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1536,8 +1536,12 @@ def test_repeat_0_size():


def test_result_type_bug_1874():
dts_bool = [True, np.bool_(True)]
dts_ints = [int(1), np.int64(1)]
py_sc = True
np_sc = np.asarray([py_sc])[0]
dts_bool = [py_sc, np_sc]
py_sc = int(1)
np_sc = np.asarray([py_sc])[0]
dts_ints = [py_sc, np_sc]
dts_floats = [float(1), np.float64(1)]
dts_complexes = [complex(1), np.complex128(1)]

Expand Down