Skip to content

Triage non-reproducible test failure in CI #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oleksandr-pavlyk wants to merge 5 commits into from
Closed

Triage non-reproducible test failure in CI #1871

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b991558
Add print statement
oleksandr-pavlyk Oct 20, 2024
b0874da
Run test_linux with pytest -s
oleksandr-pavlyk Oct 20, 2024
3c32158
Add step to run just the failing test
oleksandr-pavlyk Oct 20, 2024
f1be356
Renamed the test and commented out steps other than those failing
oleksandr-pavlyk Oct 20, 2024
4971d64
Use operator.index instead of int
oleksandr-pavlyk Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use operator.index instead of int
  • Loading branch information
@oleksandr-pavlyk
oleksandr-pavlyk committed Oct 20, 2024
commit 4971d64a72ddbf8093597ba20e3fb4e904dac406
7 changes: 4 additions & 3 deletions dpctl/tensor/_manipulation_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ def roll(x, /, shift, *, axis=None):
res = dpt.empty(
x.shape, dtype=x.dtype, usm_type=x.usm_type, sycl_queue=exec_q
)
sz = x.size
sz = operator.index(x.size)
shift = (shift % sz) if sz > 0 else 0
dep_evs = _manager.submitted_events
hev, roll_ev = ti._copy_usm_ndarray_for_roll_1d(
Expand All @@ -373,8 +373,9 @@ def roll(x, /, shift, *, axis=None):
] * x.ndim
shape = x.shape
for sh, ax in broadcasted:
n_i = shape[ax]
shifts[ax] = (int(shifts[ax] + sh) % int(n_i)) if n_i > 0 else 0
n_i = operator.index(shape[ax])
shifted = operator.index(shifts[ax]) + operator.index(sh)
shifts[ax] = (shifted % n_i) if n_i > 0 else 0
res = dpt.empty(
x.shape, dtype=x.dtype, usm_type=x.usm_type, sycl_queue=exec_q
)
Expand Down