Skip to content

Nonzero regression #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandr-pavlyk merged 2 commits into from
Aug 2, 2023
Merged

Nonzero regression #1323

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ded9c3
Fixes regression in tensor.nonzero introduced in gh-1300
oleksandr-pavlyk Aug 2, 2023
3fe2718
Added test for gh-1322
oleksandr-pavlyk Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixes regression in tensor.nonzero introduced in gh-1300 
Closes gh-1322

The indexes arrays must be allocated in default integral data type
for the target device.
  • Loading branch information
@oleksandr-pavlyk
oleksandr-pavlyk committed Aug 2, 2023
commit 8ded9c392e0a5adcc5a782792102a50bc73521f3
3 changes: 2 additions & 1 deletion dpctl/tensor/_copy_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,9 +517,10 @@ def _nonzero_impl(ary):
mask_nelems, dtype=cumsum_dt, sycl_queue=exec_q, order="C"
)
mask_count = ti.mask_positions(ary, cumsum, sycl_queue=exec_q)
indexes_dt = ti.default_device_int_type(exec_q.sycl_device)
indexes = dpt.empty(
(ary.ndim, mask_count),
dtype=cumsum.dtype,
dtype=indexes_dt,
usm_type=usm_type,
sycl_queue=exec_q,
order="C",
Expand Down