Skip to content

Transitioned dpctl to require DPC++ 2023, removed host related functions, fixed linker crash, enabled SyclKernel.max_sub_group_size property #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandr-pavlyk merged 25 commits into from
Dec 26, 2022
Merged

Transitioned dpctl to require DPC++ 2023, removed host related functions, fixed linker crash, enabled SyclKernel.max_sub_group_size property #1028

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
9aa8e02
Used new in DPC++ 2023 option to fix linker crash
oleksandr-pavlyk Dec 22, 2022
ca987af
Added missing include to defined __SYCL_COMPILER_VERSION
oleksandr-pavlyk Dec 23, 2022
4deadb8
Skipping check for preferred_vector_width_double without fp64 aspect.
oleksandr-pavlyk Dec 23, 2022
d24dcde
Do not exercise DPCTL_HOST backend, and DPCTL_HOST_DEVICE device type…
oleksandr-pavlyk Dec 23, 2022
d1b4d27
Adjusted test for device-specific kernel descriptor private-memory.
oleksandr-pavlyk Dec 23, 2022
1389a32
Change gen_docs.py to use Release build
oleksandr-pavlyk Dec 23, 2022
77efc73
Fixed test_cython_api
oleksandr-pavlyk Dec 23, 2022
2e54bf6
Removed 2023_SWITCHOVER
oleksandr-pavlyk Dec 23, 2022
3267ef6
Added static assert for minimum require compiler version
oleksandr-pavlyk Dec 23, 2022
b4fa9c5
Removed no longer needed include
oleksandr-pavlyk Dec 23, 2022
9259083
Removed obsolete comment
oleksandr-pavlyk Dec 23, 2022
c73190c
Implemented SyclKernel.max_sub_group_size
oleksandr-pavlyk Dec 23, 2022
72622e0
Modified test_async_submit to check status right away
oleksandr-pavlyk Dec 23, 2022
cee5afe
Removed aspect_host, select_host_device, has_host_device
oleksandr-pavlyk Dec 23, 2022
ad85e04
Removed DPCTL_HOST and DPCTL_HOST_DEVICE
oleksandr-pavlyk Dec 23, 2022
97551b6
Removed host-related functions/methods
oleksandr-pavlyk Dec 24, 2022
9aa909f
Added item about removal of Python API functions to ChangeLog
oleksandr-pavlyk Dec 24, 2022
d6ed339
Removed select_host_device instance devices from dpctl_device_selector
oleksandr-pavlyk Dec 24, 2022
8676efe
Documented addition of dpctl.program.SyclKernel.max_sub_group_size pr…
oleksandr-pavlyk Dec 24, 2022
03de8fe
Used Release build type in generate documentation workflow, it is way…
oleksandr-pavlyk Dec 24, 2022
8ca2dd5
Use -g1 for debug build to reduce size of SO with offloaded sections
oleksandr-pavlyk Dec 24, 2022
4b0f484
adjust --ignore-filename-regex to reflect changes in DPC++ 2023
oleksandr-pavlyk Dec 24, 2022
cfefca3
Corrected -ignore-filename-regex in libsyclinterface/tests/CMakeLists…
oleksandr-pavlyk Dec 25, 2022
44a8e38
More verbosity to steps of coverall uploads
oleksandr-pavlyk Dec 26, 2022
3db9c8d
Use different exclusion pattern: /tmp/icpx*
oleksandr-pavlyk Dec 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjusted test for device-specific kernel descriptor private-memory. 
With 2022.2 a non-zero value was being returned for interoperability
kernel compiler for GPU device, but it now returns zero with 2023.0
compiler.
  • Loading branch information
@oleksandr-pavlyk
oleksandr-pavlyk committed Dec 23, 2022
commit d1b4d27006eb7830a5ea41e8911632f092033855
10 changes: 2 additions & 8 deletions libsyclinterface/tests/test_sycl_kernel_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,14 +145,8 @@ TEST_P(TestDPCTLSyclKernelInterface, CheckGetPrivateMemSize)
EXPECT_NO_FATAL_FAILURE(axpy_private_mem_sz =
DPCTLKernel_GetPrivateMemSize(AxpyKRef));

if (DPCTLDevice_IsGPU(DRef)) {
ASSERT_TRUE(add_private_mem_sz != 0);
ASSERT_TRUE(axpy_private_mem_sz != 0);
}
else {
ASSERT_TRUE(add_private_mem_sz >= 0);
ASSERT_TRUE(axpy_private_mem_sz >= 0);
}
ASSERT_TRUE(add_private_mem_sz >= 0);
ASSERT_TRUE(axpy_private_mem_sz >= 0);
Comment on lines +148 to +149

@oleksandr-pavlyk oleksandr-pavlyk Dec 26, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually an improvement in DPC++ RT, not a regression. Neither of the kernels use private memory.

}

TEST_P(TestDPCTLSyclKernelInterface, CheckGetMaxNumSubGroups)
Expand Down