Repository navigation
Add scripts to build Linux module wheels - #34
Merged
Merged
Conversation
jcfr
reviewed
May 29, 2017
| @@ -0,0 +1,95 @@ | |||
| #!/usr/bin/env bash | |||
Contributor
There was a problem hiding this comment.
I wonder if code with this script should be shared ? See https://github.com/InsightSoftwareConsortium/ITKPythonPackage/blob/master/scripts/internal/manylinux-build-wheels.sh
jcfr
reviewed
May 29, 2017
| if [[ -e /work/requirements-dev.txt ]]; then | ||
| ${PYBIN}/pip install -r /work/requirements-dev.txt | ||
| fi | ||
| itk_build_dir=/work/ITK-$(basename $(dirname ${PYBIN}))-manylinux1_${arch} |
Contributor
There was a problem hiding this comment.
That section seems to be the specific one
jcfr
reviewed
May 29, 2017
| @@ -0,0 +1,23 @@ | |||
| #!/bin/bash | |||
Contributor
There was a problem hiding this comment.
May be usage of the script could be documented here ?
jcfr
approved these changes
May 29, 2017
jcfr
left a comment
jcfr
left a comment
Contributor
There was a problem hiding this comment.
Nicely done.
Beside of few nitpicks that could definitively be addressed later. After CI is green. LGTM
Member
Author
|
Thanks for the reviews! Good ideas. I'll refactor to re-use common code in a follow-up PR. Also add more documentation. I think we should consider documenting with ReadTheDocs, too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.