Repository navigation
DB backup and restore fails, bad exported file format (Mac, MAMP) #55
Description
To Reproduce
- http://localhost:8888/lwt/backup_restore.php
- click "download lwt backup", file is created and downloaded (eg
lwt-backup-exp_version-2022-11-02-19-28-54.sql.gz) - on same page, "restore" section, choose that file, and click "restore from lwt backup"
*** Error: Invalid Database Restore file (possibly not created by LWT backup) ***
If I try to gunzip the file, I get an error:
MacBook-Air-2:Downloads jeff$ gunzip lwt-backup-exp_version-2022-11-02-19-28-54.sql.gz
gunzip: lwt-backup-exp_version-2022-11-02-19-28-54.sql.gz: not in gzip format
setup:
Mac, MAMP
Web Server localhost:8888
Server Software Apache/2.4.46
PHP Version 7.4.21
MySQL Version 5.7.34
This is LWT Version 2.5.2-fork (September 27 2022)
Tested on master branch:
MacBook-Air-2:lwt jeff$ git log -n 1
commit 3c10d17115616a5dcba51e16c0d19501cbc550cb (HEAD -> master, upstream/master, upstream/HEAD, origin/master)
Activity
[-]DB backup and restore fails[/-][+]DB backup and restore fails, bad exported file format (Mac, MAMP)[/+]HugoFara commentedon Nov 4, 2022
I tested and reproduced your issue. There is something wrong with the generated gzip file, but I think the issue is quite small. I should be able to fix it tomorrow.
Fixed #55: database backup was broken.
Merge branch 'dev': fixed database backup (#55).
HugoFara commentedon Nov 5, 2022
Hi Jeff!
I managed to find the issue, I think I got a good a specimen from the pandemonium of bugs. It was basically the following:
backup_restore.phpincludeinc/database_connect.php.inc/database_connect.phpstarts with\n<?php.\nin plain text.\nto the gzip-encoded content.It took me three hours to remove a "\n", but now there are now longer pesky data when loading pages. I also updated the headers, that can be a potential cause for download failure.
So now you should be able to break and restore you database without much risk. Enjoy! 😆
jzohrab commentedon Nov 5, 2022
great find, good work!